Skip to content

Commit 758510a

Browse files
authored
Merge pull request #1278 from pichfl/mainmatter/drop-8
Purge Node 8 related code
2 parents 5fe6301 + 9ad7251 commit 758510a

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

src/get-start-and-end-commands.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ const nodeModulesIgnore = `
1919
/node_modules/
2020
`;
2121

22-
// remove when node 8 is dropped
23-
const lastNode8Version = '3.16';
24-
2522
module.exports = function getStartAndEndCommands({
2623
packageJson,
2724
baseBlueprint,
@@ -68,7 +65,7 @@ module.exports = function getStartAndEndCommands({
6865
// first version that supports blueprints with versions
6966
7067
// https://github.com/ember-cli/ember-cli/pull/8571
71-
startRange = endRange = `>=3.11.0-beta.1 <${lastNode8Version}`;
68+
startRange = endRange = `>=3.11.0-beta.1`;
7269
}
7370

7471
return {

test/unit/get-start-and-end-commands-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ describe(_getStartAndEndCommands, function () {
270270
name: blueprint,
271271
version: startVersion
272272
},
273-
packageRange: '>=3.11.0-beta.1 <3.16'
273+
packageRange: '>=3.11.0-beta.1'
274274
},
275275
endOptions: {
276276
baseBlueprint: {
@@ -281,7 +281,7 @@ describe(_getStartAndEndCommands, function () {
281281
name: blueprint,
282282
version: endVersion
283283
},
284-
packageRange: '>=3.11.0-beta.1 <3.16'
284+
packageRange: '>=3.11.0-beta.1'
285285
}
286286
});
287287
});

0 commit comments

Comments
 (0)