Skip to content

Commit 714b989

Browse files
author
Kelly Selden
committed
test notify-property-change codemod
1 parent 081e321 commit 714b989

4 files changed

Lines changed: 32 additions & 1 deletion

File tree

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,14 @@
11
import Controller from '@ember/controller';
2+
import Ember from 'ember';
23

34
export default Controller.extend({
5+
actions: {
6+
foo(object) {
7+
this.doStuff(object);
8+
Ember.notifyPropertyChange(object, 'someProperty');
9+
10+
this.doStuff(object);
11+
object.notifyPropertyChange('someProperty');
12+
}
13+
}
414
});
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,15 @@
11
import Ember from 'ember';
22

33
export default Ember.Controller.extend({
4+
actions: {
5+
foo(object) {
6+
Ember.propertyWillChange(object, 'someProperty');
7+
this.doStuff(object);
8+
Ember.propertyDidChange(object, 'someProperty');
9+
10+
object.propertyWillChange('someProperty');
11+
this.doStuff(object);
12+
object.propertyDidChange('someProperty');
13+
}
14+
}
415
});
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,14 @@
11
import Controller from '@ember/controller';
2+
import Ember from 'ember';
23

34
export default Controller.extend({
5+
actions: {
6+
foo(object) {
7+
this.doStuff(object);
8+
Ember.notifyPropertyChange(object, 'someProperty');
9+
10+
this.doStuff(object);
11+
object.notifyPropertyChange('someProperty');
12+
}
13+
}
414
});

test/integration/index-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ applicable codemods: `);
276276
from version: 3.2.0-beta.1
277277
to version: 3.3.0
278278
output repo: https://github.com/ember-cli/ember-new-output
279-
applicable codemods: ember-modules-codemod, ember-qunit-codemod, ember-test-helpers-codemod, es5-getter-ember-codemod, qunit-dom-codemod`);
279+
applicable codemods: ember-modules-codemod, ember-qunit-codemod, ember-test-helpers-codemod, es5-getter-ember-codemod, notify-property-change, qunit-dom-codemod`);
280280
});
281281

282282
it('lists codemods', async function() {

0 commit comments

Comments
 (0)