Skip to content

Commit 6d79ffd

Browse files
rajasegarKelly Selden
authored andcommitted
try cp-property-map codemod from ember-3x-codemods (#727)
* [FEAT] Add computed-property property() Modifier codemod
1 parent ba9d969 commit 6d79ffd

3 files changed

Lines changed: 15 additions & 0 deletions

File tree

test/fixtures/codemod/latest-node/my-app/app/controllers/application.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import Controller from '@ember/controller';
22
import Ember from 'ember';
33
import { assign } from '@ember/polyfills';
4+
import { map } from '@ember/object/computed';
45

56
export default Controller.extend({
67
fullName: computed('firstName', 'lastName', function() {
@@ -11,6 +12,10 @@ export default Controller.extend({
1112
return `${this.firstName} ${this.lastName}`;
1213
},
1314

15+
friendNames: map('friends', ['nameKey'], function(friend) {
16+
return friend[this.nameKey];
17+
}),
18+
1419
actions: {
1520
foo(object) {
1621
this.doStuff(object);

test/fixtures/codemod/local/my-app/app/controllers/application.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import Ember from 'ember';
22
import { merge } from '@ember/polyfills';
3+
import { map } from '@ember/object/computed';
34

45
export default Ember.Controller.extend({
56
fullName: computed(function() {
@@ -10,6 +11,10 @@ export default Ember.Controller.extend({
1011
return `${this.firstName} ${this.lastName}`;
1112
}).volatile('firstName', 'lastName'),
1213

14+
friendNames: map('friends', function(friend) {
15+
return friend[this.nameKey];
16+
}).property('nameKey'),
17+
1318
actions: {
1419
foo(object) {
1520
Ember.propertyWillChange(object, 'someProperty');

test/fixtures/codemod/min-node/my-app/app/controllers/application.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import Controller from '@ember/controller';
22
import Ember from 'ember';
33
import { assign } from '@ember/polyfills';
4+
import { map } from '@ember/object/computed';
45

56
export default Controller.extend({
67
fullName: computed('firstName', 'lastName', function() {
@@ -11,6 +12,10 @@ export default Controller.extend({
1112
return `${this.firstName} ${this.lastName}`;
1213
},
1314

15+
friendNames: map('friends', ['nameKey'], function(friend) {
16+
return friend[this.nameKey];
17+
}),
18+
1419
actions: {
1520
foo(object) {
1621
this.doStuff(object);

0 commit comments

Comments
 (0)