Skip to content

Commit 530c182

Browse files
author
Kelly Selden
committed
remove unneeded findBlueprint
1 parent 8ef0968 commit 530c182

3 files changed

Lines changed: 15 additions & 39 deletions

File tree

src/check-for-blueprint-updates.js

Lines changed: 9 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -17,41 +17,25 @@ async function checkForBlueprintUpdates({
1717
blueprint: blueprint.location || blueprint.packageName
1818
});
1919

20-
let currentVersion;
20+
let currentVersion = blueprint.version;
2121
let latestVersion;
2222

2323
if (parsedPackage.name) {
2424
let versions = await getVersions(parsedPackage.name);
2525

26-
let tagVersions = await Promise.all([
27-
getTagVersion({
28-
range: blueprint.version,
29-
versions,
30-
packageName: blueprint.packageName
31-
}),
32-
getTagVersion({
33-
range: toDefault,
34-
versions,
35-
packageName: blueprint.packageName
36-
})
37-
]);
38-
39-
currentVersion = tagVersions[0];
40-
latestVersion = tagVersions[1];
26+
latestVersion = await getTagVersion({
27+
range: toDefault,
28+
versions,
29+
packageName: blueprint.packageName
30+
});
4131
} else {
42-
let packages = await Promise.all([
43-
downloadPackage(parsedPackage.name, parsedPackage.url, blueprint.version),
44-
downloadPackage(parsedPackage.name, parsedPackage.url, toDefault)
45-
]);
32+
let downloadedPackage = await downloadPackage(parsedPackage.name, parsedPackage.url, toDefault);
4633

47-
currentVersion = packages[0].version;
48-
latestVersion = packages[1].version;
34+
latestVersion = downloadedPackage.version;
4935
}
5036

5137
return {
52-
packageName: blueprint.packageName,
53-
name: blueprint.name,
54-
currentVersion,
38+
blueprint,
5539
latestVersion,
5640
isUpToDate: currentVersion === latestVersion
5741
};

src/choose-blueprint-updates.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,15 @@
22

33
const checkForBlueprintUpdates = require('./check-for-blueprint-updates');
44
const inquirer = require('inquirer');
5-
const findBlueprint = require('./find-blueprint');
65
const loadSafeBlueprint = require('./load-safe-blueprint');
76

87
const toDefault = require('./args').to.default;
98

109
function formatBlueprintLine({
11-
name,
12-
currentVersion,
10+
blueprint,
1311
latestVersion
1412
}) {
15-
return `${name}, current: ${currentVersion}, latest: ${latestVersion}`;
13+
return `${blueprint.name}, current: ${blueprint.version}, latest: ${latestVersion}`;
1614
}
1715

1816
async function chooseBlueprint({
@@ -82,7 +80,7 @@ async function chooseBlueprintUpdates({
8280
message: 'Blueprint updates have been found. Which one would you like to update?'
8381
});
8482

85-
existingBlueprint = findBlueprint(emberCliUpdateJson, blueprintUpdate.packageName, blueprintUpdate.name);
83+
existingBlueprint = blueprintUpdate.blueprint;
8684

8785
let latestVersion = `${blueprintUpdate.latestVersion} (latest)`;
8886

test/integration/check-for-blueprint-updates-test.js

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -42,23 +42,17 @@ describe(checkForBlueprintUpdates, function() {
4242

4343
expect(blueprintUpdates).to.deep.equal([
4444
{
45-
packageName: localBlueprint.packageName,
46-
name: localBlueprint.name,
47-
currentVersion: localBlueprint.version,
45+
blueprint: localBlueprint,
4846
latestVersion: (await loadSafeBlueprintFile('test/fixtures/blueprint/app/local-app/merge/my-app/config/ember-cli-update.json')).blueprints[1].version,
4947
isUpToDate: false
5048
},
5149
{
52-
packageName: urlBlueprint.packageName,
53-
name: urlBlueprint.name,
54-
currentVersion: urlBlueprint.version,
50+
blueprint: urlBlueprint,
5551
latestVersion: (await loadSafeBlueprintFile('test/fixtures/blueprint/app/remote-app/merge/my-app/config/ember-cli-update.json')).blueprints[0].version,
5652
isUpToDate: false
5753
},
5854
{
59-
packageName: npmBlueprint.packageName,
60-
name: npmBlueprint.name,
61-
currentVersion: npmBlueprint.version,
55+
blueprint: npmBlueprint,
6256
latestVersion: npmBlueprint.version,
6357
isUpToDate: true
6458
}

0 commit comments

Comments
 (0)