Skip to content

Commit 4f782bb

Browse files
author
Kelly Selden
committed
pin the reset fixtures to 2.11.1
so I don't have to keep updating them when I want to test a new ember-cli version
1 parent 1f68d94 commit 4f782bb

28 files changed

Lines changed: 245 additions & 160 deletions

test/acceptance/ember-cli-update-test.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,8 @@ describe(function() {
320320
fixturesPath: 'test/fixtures/app/local',
321321
commitMessage: 'my-app',
322322
init: true,
323-
reset: true
323+
reset: true,
324+
to: '2.11.1'
324325
})).promise;
325326

326327
expect(path.join(tmpPath, 'config/ember-cli-update.json')).to.be.a.file()
@@ -420,7 +421,7 @@ describe(function() {
420421
let {
421422
status
422423
} = await (await merge({
423-
fixturesPath: 'test/fixtures/app/merge',
424+
fixturesPath: 'test/fixtures/app/local',
424425
commitMessage: 'my-app',
425426
bootstrap: true
426427
})).promise;
@@ -433,7 +434,7 @@ describe(function() {
433434
await fs.remove(path.join(tmpPath, 'config/ember-cli-update.json'));
434435

435436
fixtureCompare({
436-
mergeFixtures: 'test/fixtures/app/merge/my-app'
437+
mergeFixtures: 'test/fixtures/app/local/my-app'
437438
});
438439
});
439440

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"directory": "bower_components",
3+
"analytics": false
4+
}

test/fixtures/app/reset/my-app/.eslintignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

test/fixtures/app/reset/my-app/.eslintrc.js

Lines changed: 0 additions & 39 deletions
This file was deleted.

test/fixtures/app/reset/my-app/.gitignore

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,4 @@
1414
/coverage/*
1515
/libpeerconnection.log
1616
npm-debug.log*
17-
yarn-error.log
1817
testem.log
19-
20-
# ember-try
21-
.node_modules.ember-try/
22-
bower.json.ember-try
23-
package.json.ember-try
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
{
2+
"predef": [
3+
"document",
4+
"window",
5+
"-Promise"
6+
],
7+
"browser": true,
8+
"boss": true,
9+
"curly": true,
10+
"debug": false,
11+
"devel": true,
12+
"eqeqeq": true,
13+
"evil": true,
14+
"forin": false,
15+
"immed": false,
16+
"laxbreak": false,
17+
"newcap": true,
18+
"noarg": true,
19+
"noempty": false,
20+
"nonew": false,
21+
"nomen": false,
22+
"onevar": false,
23+
"plusplus": false,
24+
"regexp": false,
25+
"undef": true,
26+
"sub": true,
27+
"strict": false,
28+
"white": false,
29+
"eqnull": true,
30+
"esversion": 6,
31+
"unused": true
32+
}
Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,24 @@
11
---
22
language: node_js
33
node_js:
4-
- "6"
4+
- "4"
55

66
sudo: false
7-
dist: trusty
8-
9-
addons:
10-
chrome: stable
117

128
cache:
139
directories:
1410
- $HOME/.npm
15-
16-
env:
17-
global:
18-
# See https://git.io/vdao3 for details.
19-
- JOBS=1
11+
- $HOME/.cache # includes bowers cache
2012

2113
before_install:
2214
- npm config set spin false
15+
- npm install -g bower phantomjs-prebuilt
16+
- bower --version
17+
- phantomjs --version
18+
19+
install:
20+
- npm install
21+
- bower install
2322

2423
script:
25-
- npm run lint:js
2624
- npm test

test/fixtures/app/reset/my-app/README.md

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,21 +8,22 @@ A short introduction of this app could easily go here.
88
You will need the following things properly installed on your computer.
99

1010
* [Git](https://git-scm.com/)
11-
* [Node.js](https://nodejs.org/) (with npm)
11+
* [Node.js](https://nodejs.org/) (with NPM)
12+
* [Bower](https://bower.io/)
1213
* [Ember CLI](https://ember-cli.com/)
13-
* [Google Chrome](https://google.com/chrome/)
14+
* [PhantomJS](http://phantomjs.org/)
1415

1516
## Installation
1617

1718
* `git clone <repository-url>` this repository
1819
* `cd my-app`
1920
* `npm install`
21+
* `bower install`
2022

2123
## Running / Development
2224

2325
* `ember serve`
2426
* Visit your app at [http://localhost:4200](http://localhost:4200).
25-
* Visit your tests at [http://localhost:4200/tests](http://localhost:4200/tests).
2627

2728
### Code Generators
2829

@@ -33,11 +34,6 @@ Make use of the many generators for code, try `ember help generate` for more det
3334
* `ember test`
3435
* `ember test --server`
3536

36-
### Linting
37-
38-
* `npm run lint:js`
39-
* `npm run lint:js -- --fix`
40-
4137
### Building
4238

4339
* `ember build` (development)
@@ -49,7 +45,7 @@ Specify what it takes to deploy your app.
4945

5046
## Further Reading / Useful Links
5147

52-
* [ember.js](https://emberjs.com/)
48+
* [ember.js](http://emberjs.com/)
5349
* [ember-cli](https://ember-cli.com/)
5450
* Development Browser Extensions
5551
* [ember inspector for chrome](https://chrome.google.com/webstore/detail/ember-inspector/bmdblncegkenkacieihfhpjfppoconhi)

test/fixtures/app/reset/my-app/app/app.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
1-
import Application from '@ember/application';
1+
import Ember from 'ember';
22
import Resolver from './resolver';
33
import loadInitializers from 'ember-load-initializers';
44
import config from './config/environment';
55

6-
const App = Application.extend({
6+
let App;
7+
8+
Ember.MODEL_FACTORY_INJECTIONS = true;
9+
10+
App = Ember.Application.extend({
711
modulePrefix: config.modulePrefix,
812
podModulePrefix: config.podModulePrefix,
913
Resolver

test/fixtures/app/reset/my-app/app/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99

1010
{{content-for "head"}}
1111

12-
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/vendor.css">
13-
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/my-app.css">
12+
<link rel="stylesheet" href="{{rootURL}}assets/vendor.css">
13+
<link rel="stylesheet" href="{{rootURL}}assets/my-app.css">
1414

1515
{{content-for "head-footer"}}
1616
</head>

0 commit comments

Comments
 (0)