Merge pull request #1243 from ember-cli/fix-ci

Fix CI

Author: mansona

.github/workflows/ci.yml

@@ -20,6 +20,7 @@ jobs:
     - uses: actions/setup-node@v3
       with:
         node-version: 14
+        cache: 'npm'
 
     - run: npm ci
     - run: npm run lint
@@ -28,22 +29,22 @@ jobs:
     needs: lint
 
     strategy:
+      fail-fast: false
       matrix:
         os:
-        - ubuntu-latest
-        - macos-latest
+          - ubuntu-latest
+          - macos-latest
         node:
-        - 14
-        # - '*'
+          - 14
+          - 16
+          - 18
+          - 20
         test-command:
-        - test:bin
-        - test:fast
+          - test:bin
+          - test:fast
         exclude:
-        # - os: macos-latest
-        #   node: '*'
-        - os: macos-latest
-          node: 14
-          test-command: test:fast
+          - os: macos-latest
+            test-command: test:fast
 
     runs-on: ${{ matrix.os }}
 
@@ -52,6 +53,7 @@ jobs:
     - uses: actions/setup-node@v3
       with:
         node-version: ${{ matrix.node }}
+        cache: 'npm'
 
     # for test cache hits
     - run: npm i -g [email protected]
@@ -73,12 +75,13 @@ jobs:
     - uses: actions/checkout@v3
       with:
         ref: ${{ github.head_ref }}
-        token: ${{ secrets.GitHubToken }}
+
     - uses: actions/setup-node@v3
       with:
         node-version: 14
+        cache: 'npm'
 
-    - uses: kellyselden/ember-cli-update-action@v3
+    - uses: kellyselden/ember-cli-update-action@v5
       with:
         autofix_command: npm run lint -- --fix
         ignore_to: true

appveyor.yml

@@ -1,9 +1,6 @@
 environment:
   matrix:
-    # node 14.5 has a regression
-    # npm ERR! cb.apply is not a function
-    # - nodejs_version: "14"
-    - nodejs_version: "14.4"
+    - nodejs_version: "14"
   DEBUG: "ember-cli-update,boilerplate-update,git-diff-apply"
 
 branches:
@@ -19,15 +16,6 @@ install:
   - ps: Install-Product node $env:nodejs_version
   # for test cache hits
   - npm i -g [email protected]
-  - ps: >-
-      [Environment]::SetEnvironmentVariable("NODE_LTS", "true", "User")
-  - RefreshEnv
-  - where npx
-  # don't accidentally use the global npx
-  - ps: rm "C:\Program Files\nodejs\npx*"
-  - ps: rm C:\Users\appveyor\AppData\Roaming\npm\npx*
-  # test that we can't find it
-  - ps: if (gcm npx) { exit }
   - npm ci
 
 # Post-install test scripts.
@@ -38,7 +26,7 @@ test_script:
 
 # http://help.appveyor.com/discussions/questions/1310-delete-cache
 cache:
-  - node_modules -> package.json
+  - node_modules -> package-lock.json
 
 # Don't actually build.
 build: off