Skip to content

Commit 9bc1c2d

Browse files
committed
Update lints
1 parent 0018431 commit 9bc1c2d

5 files changed

Lines changed: 19 additions & 27 deletions

File tree

.try.mjs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,17 +26,17 @@ const compatDeps = {
2626
function compatLTS(version) {
2727
return {
2828
name: `ember-lts-${version}`,
29-
npm: {
30-
devDependencies: {
31-
'ember-source': `~${version}`,
32-
...compatDeps,
33-
},
29+
npm: {
30+
devDependencies: {
31+
'ember-source': `~${version}`,
32+
...compatDeps,
3433
},
35-
env: {
36-
ENABLE_COMPAT_BUILD: true,
37-
},
38-
files: compatFiles,
39-
}
34+
},
35+
env: {
36+
ENABLE_COMPAT_BUILD: true,
37+
},
38+
files: compatFiles,
39+
};
4040
}
4141

4242
export default {

tests/acceptance/workflow-config-test.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
/* eslint-disable qunit/require-expect */
2-
31
import { deprecate } from '@ember/debug';
42
import { module } from 'qunit';
53
import test from '../helpers/debug-test';
@@ -134,7 +132,6 @@ module('workflow config', function (hooks) {
134132
window.Testem.handleConsoleMessage = function (passedMessage) {
135133
count++;
136134
if (count <= limit) {
137-
// eslint-disable-next-line qunit/no-conditional-assertions
138135
assert.strictEqual(
139136
passedMessage.substr(0, expected.length),
140137
expected,

tests/test-helper.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import EmberApp from 'ember-strict-application-resolver';
22
import { loadTests } from 'ember-qunit/test-loader';
33
import EmberRouter from '@ember/routing/router';
4+
import { dependencySatisfies } from '@embroider/macros';
45
import * as QUnit from 'qunit';
56
import { setApplication } from '@ember/test-helpers';
67
import { setup } from 'qunit-dom';
@@ -23,15 +24,14 @@ class TestApp extends EmberApp {
2324
Router.map(function () {});
2425

2526
export function start() {
26-
27-
/**
28-
* We only need to explicitly call load tests when we're on a newer ember-qunit. This check is here
29-
* because we have an ember-try setup that tests ember versions that aren't supported on the newer
30-
* ember-qunit so we need to downgrade ember-qunit for them too
31-
*/
32-
if (!dependencySatisfies('ember-qunit', '<9.0.0')) {
33-
loadTests();
34-
}
27+
/**
28+
* We only need to explicitly call load tests when we're on a newer ember-qunit. This check is here
29+
* because we have an ember-try setup that tests ember versions that aren't supported on the newer
30+
* ember-qunit so we need to downgrade ember-qunit for them too
31+
*/
32+
if (!dependencySatisfies('ember-qunit', '<9.0.0')) {
33+
loadTests();
34+
}
3535
setApplication(
3636
TestApp.create({
3737
autoboot: false,

tests/unit/deprecation-collector-test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable qunit/require-expect */
21
/* eslint no-console: 0 */
32

43
import { module } from 'qunit';

tests/unit/handle-deprecation-workflow-test.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ module('handleDeprecationWorkflow', function (hooks) {
100100
assert.ok(true, 'Deprecation did not raise');
101101
});
102102

103-
// eslint-disable-next-line qunit/require-expect
104103
test('deprecation logs with string matcher', function (assert) {
105104
assert.expect(1);
106105

@@ -172,7 +171,6 @@ module('handleDeprecationWorkflow', function (hooks) {
172171
assert.ok(true, 'Deprecation did not raise');
173172
});
174173

175-
// eslint-disable-next-line qunit/require-expect
176174
test('deprecation logs with regex matcher', function (assert) {
177175
assert.expect(1);
178176

@@ -268,7 +266,6 @@ module('handleDeprecationWorkflow', function (hooks) {
268266
assert.ok(true, 'Deprecation did not raise');
269267
});
270268

271-
// eslint-disable-next-line qunit/require-expect
272269
test('deprecation logs with id matcher', function (assert) {
273270
assert.expect(1);
274271

@@ -340,7 +337,6 @@ module('handleDeprecationWorkflow', function (hooks) {
340337
assert.ok(true, 'Deprecation did not raise');
341338
});
342339

343-
// eslint-disable-next-line qunit/require-expect
344340
test('deprecation logs with id regex', function (assert) {
345341
assert.expect(1);
346342

0 commit comments

Comments
 (0)