Stop hitting 3rd party API in tests

[mansona]

While working on a release I noticed that we added this: https://github.com/ember-cli/ember-app-blueprint/pull/190/changes#diff-d82802433d6969e1efb5c1252cead2d60dccf5ed05b6125ace6e81bf5381e74eR10

we really shouldn't be hitting a live API during tests, we should make sure that this isn't the case in PR reviews

[NullVoxPopuli]

Seemed less controversial than adding msw, and mirage is off the table ;)

[mansona]

mirage is not off the table at all, but you don't need to go that far. You can just have static json on disk to do a basic test

[NullVoxPopuli]

Anyone picking up mirage rn, is signing up for pain.

Just a json file would work here, ye

[void-mAlex]

depending on the usecase there is nothing extremely wrong with mirage and it's not really a pain especially if you pick it up fresh without all the magic ember-data lookups it's quite decent (sure it doesn't scale the best at really large projects)

there are tools that work better out there like msw etc, but those need some really heavy lifting to make them compatible with other conflicting things like PWA which will both fight over the service worker and you want to make extra sure that msw doesn't ship to production ( well unless you expressly want that)