From 4d2307e5b8ad6009e8f890b977bda5f3c9712524 Mon Sep 17 00:00:00 2001 From: Alexey Kulakov Date: Sun, 5 Oct 2025 19:07:41 -0700 Subject: [PATCH 1/6] chore: remove `@glint/environment-ember-*` --- files/unpublished-development-types/index.d.ts | 3 --- .../my-addon/unpublished-development-types/index.d.ts | 2 -- tests/fixtures/explicit-imports/test-app/types/registry.d.ts | 3 --- 3 files changed, 8 deletions(-) diff --git a/files/unpublished-development-types/index.d.ts b/files/unpublished-development-types/index.d.ts index 45276a7..9cfd429 100644 --- a/files/unpublished-development-types/index.d.ts +++ b/files/unpublished-development-types/index.d.ts @@ -1,9 +1,6 @@ // Add any types here that you need for local development only. // These will *not* be published as part of your addon, so be careful that your published code does not rely on them! -import '@glint/environment-ember-loose'; -import '@glint/environment-ember-template-imports'; - // Uncomment if you need to support consuming projects in loose mode // // declare module '@glint/environment-ember-loose/registry' { diff --git a/tests/fixtures/explicit-imports/my-addon/unpublished-development-types/index.d.ts b/tests/fixtures/explicit-imports/my-addon/unpublished-development-types/index.d.ts index 3ca67c1..4f8a2c8 100644 --- a/tests/fixtures/explicit-imports/my-addon/unpublished-development-types/index.d.ts +++ b/tests/fixtures/explicit-imports/my-addon/unpublished-development-types/index.d.ts @@ -1,8 +1,6 @@ // Add any types here that you need for local development only. // These will *not* be published as part of your addon, so be careful that your published code does not rely on them! -import '@glint/environment-ember-loose'; - import { default as MyRegistry } from '../src/template-registry'; declare module '@glint/environment-ember-loose/registry' { diff --git a/tests/fixtures/explicit-imports/test-app/types/registry.d.ts b/tests/fixtures/explicit-imports/test-app/types/registry.d.ts index 0f5eeae..3fa44b6 100644 --- a/tests/fixtures/explicit-imports/test-app/types/registry.d.ts +++ b/tests/fixtures/explicit-imports/test-app/types/registry.d.ts @@ -1,6 +1,3 @@ -import '@glint/environment-ember-loose'; -import '@glint/environment-ember-template-imports'; - import { default as MyAddonRegistry } from 'my-addon/template-registry'; declare module '@glint/environment-ember-loose/registry' { From 1c24206982b2ccec639fe7e8d45fcdbd7fd5364e Mon Sep 17 00:00:00 2001 From: Alexey Kulakov Date: Sun, 5 Oct 2025 19:33:44 -0700 Subject: [PATCH 2/6] remove registry declarations --- files/unpublished-development-types/index.d.ts | 10 ---------- .../unpublished-development-types/index.d.ts | 13 ------------- .../explicit-imports/test-app/types/registry.d.ts | 6 ------ 3 files changed, 29 deletions(-) diff --git a/files/unpublished-development-types/index.d.ts b/files/unpublished-development-types/index.d.ts index 9cfd429..8b13789 100644 --- a/files/unpublished-development-types/index.d.ts +++ b/files/unpublished-development-types/index.d.ts @@ -1,11 +1 @@ -// Add any types here that you need for local development only. -// These will *not* be published as part of your addon, so be careful that your published code does not rely on them! -// Uncomment if you need to support consuming projects in loose mode -// -// declare module '@glint/environment-ember-loose/registry' { -// export default interface Registry { -// // Add any registry entries from other addons here that your addon itself uses (in non-strict mode templates) -// // See https://typed-ember.gitbook.io/glint/using-glint/ember/using-addons -// } -// } diff --git a/tests/fixtures/explicit-imports/my-addon/unpublished-development-types/index.d.ts b/tests/fixtures/explicit-imports/my-addon/unpublished-development-types/index.d.ts index 4f8a2c8..e69de29 100644 --- a/tests/fixtures/explicit-imports/my-addon/unpublished-development-types/index.d.ts +++ b/tests/fixtures/explicit-imports/my-addon/unpublished-development-types/index.d.ts @@ -1,13 +0,0 @@ -// Add any types here that you need for local development only. -// These will *not* be published as part of your addon, so be careful that your published code does not rely on them! - -import { default as MyRegistry } from '../src/template-registry'; - -declare module '@glint/environment-ember-loose/registry' { - // Remove this once entries have been added! 👇 - // eslint-disable-next-line @typescript-eslint/no-empty-interface - export default interface Registry extends MyRegistry { - // Add any registry entries from other addons here that your addon itself uses (in non-strict mode templates) - // See https://typed-ember.gitbook.io/glint/using-glint/ember/using-addons - } -} diff --git a/tests/fixtures/explicit-imports/test-app/types/registry.d.ts b/tests/fixtures/explicit-imports/test-app/types/registry.d.ts index 3fa44b6..e69de29 100644 --- a/tests/fixtures/explicit-imports/test-app/types/registry.d.ts +++ b/tests/fixtures/explicit-imports/test-app/types/registry.d.ts @@ -1,6 +0,0 @@ -import { default as MyAddonRegistry } from 'my-addon/template-registry'; - -declare module '@glint/environment-ember-loose/registry' { - // eslint-disable-next-line @typescript-eslint/no-empty-object-type - export default interface Registry extends MyAddonRegistry {} -} From 5c017508fe703968762ee7732cde22332244a79e Mon Sep 17 00:00:00 2001 From: Alexey Kulakov Date: Sun, 5 Oct 2025 19:38:53 -0700 Subject: [PATCH 3/6] bump `@glint/*` --- files/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/files/package.json b/files/package.json index 49f7c9b..2d29ad2 100644 --- a/files/package.json +++ b/files/package.json @@ -48,8 +48,8 @@ "@embroider/vite": "^1.1.5", "@eslint/js": "^9.17.0", "@glimmer/component": "^2.0.0",<% if (typescript) { %> - "@glint/ember-tsc": "^1.0.0", - "@glint/template": "^1.6.0", + "@glint/ember-tsc": "^1.0.3", + "@glint/template": "^1.6.1", "@glint/tsserver-plugin": "^2.0.0",<% } %> "@rollup/plugin-babel": "^6.0.4",<% if (typescript) { %> "@types/qunit": "^2.19.12",<% } %> From 59b424245a994e20bef12a33ba75a82a937ef8fa Mon Sep 17 00:00:00 2001 From: Alexey Kulakov Date: Sun, 5 Oct 2025 19:43:14 -0700 Subject: [PATCH 4/6] update snapshot --- tests/smoke-tests/--typescript.test.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/smoke-tests/--typescript.test.ts b/tests/smoke-tests/--typescript.test.ts index b0ec7ec..50d2ddc 100644 --- a/tests/smoke-tests/--typescript.test.ts +++ b/tests/smoke-tests/--typescript.test.ts @@ -104,7 +104,7 @@ for (let packageManager of SUPPORTED_PACKAGE_MANAGERS) { expect( await filesMatching('{dist,declarations}/**/*', addonDir), - `ensure we emit the correct files out of the box to the correct folders`, + `ensure we emit the correct files out of the box to the correct folders` ).toMatchInlineSnapshot(` [ "dist/index.js", @@ -124,10 +124,10 @@ for (let packageManager of SUPPORTED_PACKAGE_MANAGERS) { "declarations/index.d.ts.map", "declarations/template-registry.d.ts", "declarations/template-registry.d.ts.map", - "declarations/components/another-gts.gts.d.ts", - "declarations/components/another-gts.gts.d.ts.map", - "declarations/components/template-import.gts.d.ts", - "declarations/components/template-import.gts.d.ts.map", + "declarations/components/another-gts.d.ts", + "declarations/components/another-gts.d.ts.map", + "declarations/components/template-import.d.ts", + "declarations/components/template-import.d.ts.map", "declarations/services/example.d.ts", "declarations/services/example.d.ts.map", ] From 24fafadb6f61f243f991ccc0e1fdc10b1fa7ea17 Mon Sep 17 00:00:00 2001 From: Alexey Kulakov Date: Sun, 5 Oct 2025 19:45:21 -0700 Subject: [PATCH 5/6] lint --- tests/smoke-tests/--typescript.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/smoke-tests/--typescript.test.ts b/tests/smoke-tests/--typescript.test.ts index 50d2ddc..8cb99d1 100644 --- a/tests/smoke-tests/--typescript.test.ts +++ b/tests/smoke-tests/--typescript.test.ts @@ -104,7 +104,7 @@ for (let packageManager of SUPPORTED_PACKAGE_MANAGERS) { expect( await filesMatching('{dist,declarations}/**/*', addonDir), - `ensure we emit the correct files out of the box to the correct folders` + `ensure we emit the correct files out of the box to the correct folders`, ).toMatchInlineSnapshot(` [ "dist/index.js", From 814818bceb387e4f4e3ca91c432cff406cbfc04b Mon Sep 17 00:00:00 2001 From: Alexey Kulakov Date: Sun, 5 Oct 2025 19:49:34 -0700 Subject: [PATCH 6/6] lint --- files/unpublished-development-types/index.d.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/files/unpublished-development-types/index.d.ts b/files/unpublished-development-types/index.d.ts index 8b13789..e69de29 100644 --- a/files/unpublished-development-types/index.d.ts +++ b/files/unpublished-development-types/index.d.ts @@ -1 +0,0 @@ -