File tree Expand file tree Collapse file tree
default/.github/workflows Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -36,10 +36,6 @@ module.exports = async function (defaults) {
3636}
3737
3838function compatEmberScenario ( name , emberVersion ) {
39- // older LTSs would also need the compat configuration
40- let needsCompat = [ '5.4.0' , '4.12.0' ] ;
41- let needsBabelComat = needsCompat . some ( ( v ) => emberVersion . includes ( v ) ) ;
42-
4339 return {
4440 name,
4541 npm : {
@@ -56,7 +52,6 @@ function compatEmberScenario(name, emberVersion) {
5652 } ,
5753 files : {
5854 'ember-cli-build.js' : emberCliBuildJS ( ) ,
59- ...( needsBabelComat ? { 'babel.config.cjs' : compatBabel ( ) } : { } ) ,
6055 'config/optional-features.json' : JSON . stringify ( {
6156 'application-template-wrapper' : false ,
6257 'default-async-observers' : true ,
Original file line number Diff line number Diff line change 11const { buildMacros } = require ( '@embroider/macros/babel' ) ;
22
3- const { babelCompatSupport, templateCompatSupport } = require ( '@embroider/compat/babel' ) ;
3+ const {
4+ babelCompatSupport,
5+ templateCompatSupport,
6+ } = require ( '@embroider/compat/babel' ) ;
47
58const macros = buildMacros ( ) ;
69
@@ -17,7 +20,9 @@ module.exports = {
1720 [
1821 'babel-plugin-ember-template-compilation',
1922 {
20- transforms : [ ...( isCompat ? templateCompatSupport ( ) : macros . templateMacros ) ] ,
23+ transforms : [
24+ ...( isCompat ? templateCompatSupport ( ) : macros . templateMacros ) ,
25+ ] ,
2126 } ,
2227 ],
2328 [
Original file line number Diff line number Diff line change @@ -82,11 +82,15 @@ jobs:
8282 - uses : actions/setup-node@v4
8383 with :
8484 node-version : 18
85- cache : pnpm
85+ cache : npm
8686 - name : Apply Scenario
87- run : pnpm dlx @embroider/try apply ${{ matrix.name }}
87+ run : |
88+
89+ npx @embroider/try apply ${{ matrix.name }}
8890 - name : Install Dependencies
89- run : pnpm install --no-lockfile
91+ run : npm install --no-package-lock
9092 - name : Run Tests
91- run : pnpm test
93+ run : |
94+
95+ npm test
9296 env : ${{ matrix.env }}
Original file line number Diff line number Diff line change 8787 node-version : 18
8888 cache : pnpm
8989 - name : Apply Scenario
90- run : pnpm dlx @embroider/try apply ${{ matrix.name }}
90+ run : |
91+ pnpm dlx @embroider/try apply ${{ matrix.name }}
92+
9193 - name : Install Dependencies
9294 run : pnpm install --no-lockfile
9395 - name : Run Tests
94- run : pnpm test
96+ run : |
97+ pnpm test
98+
9599 env : ${{ matrix.env }}
You can’t perform that action at this time.
0 commit comments