Skip to content

Commit a31e528

Browse files
committed
fix review feedback
1 parent a6caf49 commit a31e528

3 files changed

Lines changed: 7 additions & 6 deletions

File tree

files/babel.config.cjs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@ const macros = buildMacros();
44

55
module.exports = {
66
plugins: [<% if (typescript) { %>
7-
['@babel/plugin-transform-typescript', { allowDeclareFields: true }],<% } %>
7+
['@babel/plugin-transform-typescript', {
8+
allowDeclareFields: true,
9+
onlyRemoveTypeImports: true,
10+
allowDeclareFields: true,
11+
}],<% } %>
812
[
913
'babel-plugin-ember-template-compilation',
1014
{

files/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"@embroider/core": "^4.0.0-alpha.10",
4444
"@embroider/macros": "^1.17.0-alpha.8",
4545
"@embroider/vite": "^1.0.0-alpha.12",
46-
"@ember/test-helpers": "^5.2.0",
46+
"@ember/test-helpers": "^5.2.1",
4747
"@eslint/js": "^9.17.0",<% if (typescript) { %>
4848
"@glint/core": "^1.4.0",
4949
"@glint/environment-ember-loose": "^1.4.0",

files/tests/index.html

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,11 @@
1717
<script src="/testem.js" integrity="" data-embroider-ignore></script>
1818
<script type="module">
1919
import "ember-testing";
20-
// Needed until we have:
21-
// https://github.com/emberjs/ember-test-helpers/pull/1528
22-
globalThis.EmberENV = {};
2320
</script>
2421

2522
<script type="module">
2623
import { start } from "./test-helper.js";
27-
import.meta.glob("./**/*.{js,gjs,gts}", { eager: true });
24+
import.meta.glob("./**/*.{js,ts,gjs,gts}", { eager: true });
2825
start();
2926
</script>
3027
</body>

0 commit comments

Comments
 (0)