Fix tests so that its easier to understand what is using fixtures and what isn't

Author: NullVoxPopuli

tests/fixtures/addon/components/template-import.gjs

@@ -5,7 +5,7 @@ export default class TemplateImport extends Component {
   <template>
     Hello from a GJS file
 
-    <button {{on "click" this.saySomething}}></button>
+    <button {{on "click" this.saySomething}} type="button"></button>
   </template>
 
   saySomething() {

tests/smoke-tests/defaults.test.ts

@@ -3,7 +3,7 @@ import fs from 'node:fs/promises';
 
 import tmp from 'tmp-promise';
 let localEmberCli = require.resolve('ember-cli/bin/ember');
-import { beforeAll, describe, expect, it } from 'vitest';
+import { beforeEach, beforeAll, describe, expect, it } from 'vitest';
 import { execa } from 'execa';
 import fixturify from 'fixturify';
 
@@ -103,50 +103,56 @@ for (let packageManager of SUPPORTED_PACKAGE_MANAGERS) {
       expect(exitCode).toEqual(0);
     });
 
-    it('build', async () => {
-      let buildResult = await execa({ cwd: addonDir })`${packageManager} run build`;
+    it('lint:fix with no fixtures', async () => {
+      let { exitCode } = await execa({ cwd: addonDir })`${packageManager} run lint:fix`;
 
-      expect(buildResult.exitCode).toEqual(0);
+      expect(exitCode).toEqual(0);
+    });
 
-      let contents = await dirContents(join(addonDir, 'dist'));
+    describe('with fixture', () => {
+      beforeEach(async () => {
+        let addonFixture = fixturify.readSync('./fixtures/addon');
+        fixturify.writeSync(join(addonDir, 'src'), addonFixture);
 
-      expect(contents).to.deep.equal(['_app_', 'components', 'index.js', 'index.js.map']);
-    });
+        let testFixture = fixturify.readSync('./fixtures/rendering-tests');
+        fixturify.writeSync(join(addonDir, 'tests/rendering'), testFixture);
+      });
 
-    it('lint:fix', async () => {
-      let addonFixture = fixturify.readSync('./fixtures/addon');
-      fixturify.writeSync(join(addonDir, 'src'), addonFixture);
+      it('lint:fix', async () => {
+        let { exitCode } = await execa({ cwd: addonDir })`${packageManager} run lint:fix`;
 
-      let testFixture = fixturify.readSync('./fixtures/rendering-tests');
-      fixturify.writeSync(join(addonDir, 'tests/rendering'), testFixture);
+        expect(exitCode).toEqual(0);
+      });
 
-      // Ensure that we have no lint errors.
-      // It's important to keep this along with the tests,
-      // so that we can have confidence that the lints aren't destructively changing
-      // the files in a way that would break consumers
-      let { exitCode } = await execa({ cwd: addonDir })`${packageManager} run lint:fix`;
+      it('build', async () => {
+        let buildResult = await execa({ cwd: addonDir })`${packageManager} run build`;
 
-      expect(exitCode).toEqual(0);
-    });
+        expect(buildResult.exitCode).toEqual(0);
+
+        let contents = await dirContents(join(addonDir, 'dist'));
+
+        expect(contents).to.deep.equal(['_app_', 'components', 'index.js', 'index.js.map']);
+      });
 
-    it('test', async () => {
-      // It's important that we ensure that dist directory is empty for this test, because
-      await fs.rm(join(addonDir, 'dist'), { recursive: true, force: true });
+      it('test', async () => {
+        // It's important that we ensure that dist directory is empty for this test, because
+        await fs.rm(join(addonDir, 'dist'), { recursive: true, force: true });
 
-      let testResult = await execa({ cwd: addonDir })`${packageManager} run test`;
+        let testResult = await execa({ cwd: addonDir })`${packageManager} run test`;
 
-      expect(testResult.exitCode).toEqual(0);
+        expect(testResult.exitCode).toEqual(0);
 
-      expect(testResult.stdout).includes(
-        `# tests 2
+        expect(testResult.stdout).includes(
+          `# tests 2
 # pass  2
 # skip  0
 # todo  0
 # fail  0
 
 # ok`,
-        testResult.stdout,
-      );
+          testResult.stdout,
+        );
+      });
     });
   });
 }