Add EPDFAnnot_GetRect with rect normalization.

Author: bobsingor

.changeset/fix-engines-use-normalized-rect.md

@@ -0,0 +1,5 @@
+---
+'@embedpdf/engines': patch
+---
+
+Update readPageAnnoRect to call EPDFAnnot_GetRect instead of FPDFAnnot_GetRect, ensuring annotation rectangles are always normalized. Fixes link annotations appearing below their expected position when the PDF Rect array has inverted y-coordinates.

.changeset/fix-pdfium-normalize-rect.md

@@ -0,0 +1,5 @@
+---
+'@embedpdf/pdfium': patch
+---
+
+Add EPDFAnnot_GetRect that wraps FPDFAnnot_GetRect with rect normalization. Upstream FPDFAnnot_GetRect does not normalize the rect read from the PDF dictionary, so when a PDF stores its Rect array with y1 > y2 the top/bottom values are inverted. This caused link annotations to be positioned incorrectly.

packages/engines/src/lib/pdfium/engine.ts

@@ -8307,7 +8307,7 @@ export class PdfiumNative implements IPdfiumExecutor {
       right: 0,
       bottom: 0,
     };
-    if (this.pdfiumModule.FPDFAnnot_GetRect(annotationPtr, pageRectPtr)) {
+    if (this.pdfiumModule.EPDFAnnot_GetRect(annotationPtr, pageRectPtr)) {
       pageRect.left = this.pdfiumModule.pdfium.getValue(pageRectPtr, 'float');
       pageRect.top = this.pdfiumModule.pdfium.getValue(pageRectPtr + 4, 'float');
       pageRect.right = this.pdfiumModule.pdfium.getValue(pageRectPtr + 8, 'float');

packages/pdfium/pdfium-src

@@ -61,6 +61,7 @@ export const functions = {
   EPDFAnnot_GetOpacity: [['number', 'number'] as const, 'boolean'] as const,
   EPDFAnnot_GetOverlayText: [['number', 'number', 'number'] as const, 'number'] as const,
   EPDFAnnot_GetOverlayTextRepeat: [['number'] as const, 'boolean'] as const,
+  EPDFAnnot_GetRect: [['number', 'number'] as const, 'boolean'] as const,
   EPDFAnnot_GetRectangleDifferences: [
     ['number', 'number', 'number', 'number', 'number'] as const,
     'boolean',

packages/pdfium/src/vendor/functions.ts

@@ -70,6 +70,7 @@ var createPdfium = (() => {
       '_EPDFAnnot_GetOpacity',
       '_EPDFAnnot_GetOverlayText',
       '_EPDFAnnot_GetOverlayTextRepeat',
+      '_EPDFAnnot_GetRect',
       '_EPDFAnnot_GetRectangleDifferences',
       '_EPDFAnnot_GetReplyType',
       '_EPDFAnnot_GetRichContent',
@@ -6298,6 +6299,10 @@ var createPdfium = (() => {
       'EPDFAnnot_GetUnrotatedRect',
       2,
     ));
+    var _EPDFAnnot_GetRect = (Module['_EPDFAnnot_GetRect'] = createExportWrapper(
+      'EPDFAnnot_GetRect',
+      2,
+    ));
     var _EPDFAnnot_SetAPMatrix = (Module['_EPDFAnnot_SetAPMatrix'] = createExportWrapper(
       'EPDFAnnot_SetAPMatrix',
       3,