Merge pull request #305 from embedpdf/fix/document-extension

Fixed document name extraction to always include `.pdf` extension whe…

Author: bobsingor

.changeset/friendly-pens-reply.md

@@ -0,0 +1,5 @@
+---
+'@embedpdf/plugin-document-manager': patch
+---
+
+Fixed document name extraction to always include `.pdf` extension when extracting filename from URL.

.changeset/loud-doors-shine.md

@@ -0,0 +1,5 @@
+---
+'@embedpdf/plugin-document-manager': patch
+---
+
+Added optional `name` property to `LoadDocumentUrlOptions` to allow specifying a custom document name. When not provided, the name is extracted from the URL. If extraction fails, `undefined` is returned to allow downstream handling of default names.

packages/plugin-document-manager/src/lib/document-manager-plugin.ts

@@ -237,7 +237,7 @@ export class DocumentManagerPlugin extends BasePlugin<
       return task;
     }
 
-    const documentName = this.extractNameFromUrl(options.url);
+    const documentName = options.name ?? this.extractNameFromUrl(options.url);
 
     // Store options for potential retry
     this.loadOptions.set(documentId, options);
@@ -585,14 +585,21 @@ export class DocumentManagerPlugin extends BasePlugin<
     return `doc-${Date.now()}-${Math.random().toString(36).substr(2, 9)}`;
   }
 
-  private extractNameFromUrl(url: string): string {
+  private extractNameFromUrl(url: string): string | undefined {
     try {
       const urlObj = new URL(url);
       const pathname = urlObj.pathname;
-      const filename = pathname.split('/').pop() || 'document.pdf';
-      return decodeURIComponent(filename);
+      const lastSegment = pathname.split('/').pop();
+      if (!lastSegment) {
+        return undefined;
+      }
+      let filename = decodeURIComponent(lastSegment);
+      if (!filename.toLowerCase().endsWith('.pdf')) {
+        filename += '.pdf';
+      }
+      return filename;
     } catch {
-      return 'document.pdf';
+      return undefined;
     }
   }
 

packages/plugin-document-manager/src/lib/types.ts

@@ -37,6 +37,7 @@ export interface DocumentErrorEvent {
 export interface LoadDocumentUrlOptions {
   url: string;
   documentId?: string;
+  name?: string; // Optional display name for the document. If not provided, extracted from URL
   password?: string;
   mode?: 'auto' | 'range-request' | 'full-fetch';
   requestOptions?: PdfRequestOptions;