Accept a String or charstring for database open (#290)

* Only run ci on push to main and all PRs
* Accept a String or charstring for database open

Closes #278
Closes #277

Author: warmwaffles

.github/workflows/ci.yml

@@ -3,7 +3,7 @@ name: CI
 on:
   push:
     branches:
-      - "*"
+      - "main"
   pull_request:
     branches:
       - "*"

c_src/sqlite3_nif.c

@@ -11,7 +11,6 @@
 #include <sqlite3.h>
 
 #define MAX_ATOM_LENGTH 255
-#define MAX_PATHNAME    512
 
 static ErlNifResourceType* connection_type       = NULL;
 static ErlNifResourceType* statement_type        = NULL;
@@ -197,23 +196,24 @@ exqlite_open(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[])
     connection_t* conn = NULL;
     sqlite3* db        = NULL;
     ErlNifMutex* mutex = NULL;
-    char filename[MAX_PATHNAME];
     ERL_NIF_TERM result;
+    ErlNifBinary bin;
+
+    ERL_NIF_TERM eos = enif_make_int(env, 0);
 
     if (argc != 2) {
         return enif_make_badarg(env);
     }
 
-    size = enif_get_string(env, argv[0], filename, MAX_PATHNAME, ERL_NIF_LATIN1);
-    if (size <= 0) {
+    if (!enif_inspect_iolist_as_binary(env, enif_make_list2(env, argv[0], eos), &bin)) {
         return make_error_tuple(env, "invalid_filename");
     }
 
     if (!enif_get_int(env, argv[1], &flags)) {
         return make_error_tuple(env, "invalid_flags");
     }
 
-    rc = sqlite3_open_v2(filename, &db, flags, NULL);
+    rc = sqlite3_open_v2((char*)bin.data, &db, flags, NULL);
     if (rc != SQLITE_OK) {
         return make_error_tuple(env, "database_open_failed");
     }

lib/exqlite/sqlite3.ex

@@ -35,10 +35,12 @@ defmodule Exqlite.Sqlite3 do
       the database if it doesn't already exist. Defaults to `:readwrite`.
       Note: [:readwrite, :nomutex] is not recommended.
   """
-  @spec open(String.t(), [open_opt()]) :: {:ok, db()} | {:error, reason()}
+  @spec open(String.t() | String.Chars.t(), [open_opt()]) ::
+          {:ok, db()}
+          | {:error, reason()}
   def open(path, opts \\ []) do
     mode = Keyword.get(opts, :mode, :readwrite)
-    Sqlite3NIF.open(String.to_charlist(path), flags_from_mode(mode))
+    Sqlite3NIF.open(path, flags_from_mode(mode))
   end
 
   defp flags_from_mode(:nomutex) do

test/exqlite/connection_test.exs

@@ -37,6 +37,16 @@ defmodule Exqlite.ConnectionTest do
       File.rm(path)
     end
 
+    test "connects to a file with an accented character" do
+      path = Temp.path!(prefix: "databasé")
+      {:ok, state} = Connection.connect(database: path)
+
+      assert state.path == path
+      assert state.db
+
+      File.rm(path)
+    end
+
     test "connects to a file from URL" do
       path = Temp.path!()