Skip to content

Commit ef5fd4b

Browse files
committed
Fix stray :ssl message leak in HTTP/2 integration tests
The twitter.com describe block was using @moduletag instead of @describetag, which made its connect: {"twitter.com", 443} tag apply to the whole module. That caused the top-level setup to open an HTTPS connection to twitter.com even for tests outside the describe (like the TCP h2c test), and the SSL socket's SETTINGS frame would land in the test mailbox. The previous test had a swallow-hack comment about "SSL messages sneaking in"; this removes the root cause.
1 parent 5506113 commit ef5fd4b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

test/mint/http2/integration_test.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ defmodule HTTP2.IntegrationTest do
101101
end
102102

103103
describe "twitter.com" do
104-
@moduletag connect: {"twitter.com", 443}
104+
@describetag connect: {"twitter.com", 443}
105105
@browser_user_agent "Mozilla/5.0 (Macintosh; Intel Mac OS X 11_0_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.88 Safari/537.36"
106106

107107
test "ping", %{conn: conn} do

0 commit comments

Comments
 (0)