chore(deps): update dependency @edx/frontend-platform to v8.5.6 (openedx#2995)

* chore(deps): update dependency @edx/frontend-platform to v8.5.6

* chore: misc lint fixes to get build passing

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Braden MacDonald <[email protected]>

Author: renovate[bot]

jest.config.js

@@ -1,6 +1,6 @@
 const { createConfig } = require('@openedx/frontend-build');
 
-module.exports = createConfig('jest', {
+const mergedConfig = createConfig('jest', {
   setupFilesAfterEnv: [
     'jest-expect-message',
     '<rootDir>/src/setupTest.js',
@@ -16,6 +16,24 @@ module.exports = createConfig('jest', {
     // This alias is used for plugins in the plugins/ folder only.
     '^CourseAuthoring/(.*)$': '<rootDir>/src/$1',
   },
-  modulePathIgnorePatterns: [
-  ],
+  modulePathIgnorePatterns: [],
 });
+
+// Override ts-jest config: When transforming .ts files to .js for test purposes,
+// don't report TypeScript errors for files in `node_modules/` (or any non-test files).
+// Without this, we were seeing TypeScript errors from
+//   node_modules/@edx/frontend-component-header/dist/studio-header/StudioHeader.tsx
+// cause the tests to fail, because they are included in `transformIgnorePatterns`.
+// -> If you can delete the following lines and the tests still pass, then feel free
+//    to remove this whole override. It's only necessary now while StudioHeader has some
+//    typing issues.
+mergedConfig.transform['^.+\\.[tj]sx?$'] = [
+  'ts-jest',
+  {
+    diagnostics: {
+      exclude: ['!**/*.test.*'],
+    },
+  },
+];
+
+module.exports = mergedConfig;

package-lock.json

@@ -17,6 +17,7 @@ describe('courseSettings API', () => {
 
   beforeEach(() => {
     jest.clearAllMocks();
+    // @ts-ignore since `getAuthenticatedHttpClient` is mocked. TODO: convert this test to use `initializeMocks()`
     getAuthenticatedHttpClient.mockReturnValue(mockHttpClient);
   });
 

src/advanced-settings/data/api.test.ts

@@ -66,10 +66,12 @@ const mockInvalidMultiplePermissions = [
 
 describe('useUserPermissions', () => {
   beforeEach(() => {
+    // TODO: convert this test to use `initializeMocks()` / `testUtils.tsx`
     jest.clearAllMocks();
   });
 
   it('returns allowed true when permission is valid', async () => {
+    // @ts-ignore since `getAuthenticatedHttpClient` is mocked.
     getAuthenticatedHttpClient.mockReturnValue({
       post: jest.fn().mockResolvedValueOnce({ data: mockValidSinglePermission }),
     });
@@ -86,6 +88,7 @@ describe('useUserPermissions', () => {
   });
 
   it('returns allowed false when permission is invalid', async () => {
+    // @ts-ignore since `getAuthenticatedHttpClient` is mocked.
     getAuthenticatedHttpClient.mockReturnValue({
       post: jest.fn().mockResolvedValue({ data: mockInvalidSinglePermission }),
     });
@@ -101,6 +104,7 @@ describe('useUserPermissions', () => {
   });
 
   it('returns allowed true when multiple permissions are valid', async () => {
+    // @ts-ignore since `getAuthenticatedHttpClient` is mocked.
     getAuthenticatedHttpClient.mockReturnValue({
       post: jest.fn().mockResolvedValueOnce({ data: mockValidMultiplePermissions }),
     });
@@ -118,6 +122,7 @@ describe('useUserPermissions', () => {
   });
 
   it('returns allowed false when multiple permissions are invalid', async () => {
+    // @ts-ignore since `getAuthenticatedHttpClient` is mocked.
     getAuthenticatedHttpClient.mockReturnValue({
       post: jest.fn().mockResolvedValue({ data: mockInvalidMultiplePermissions }),
     });
@@ -134,6 +139,7 @@ describe('useUserPermissions', () => {
   });
 
   it('returns allowed false when the permission is not included in the server response', async () => {
+    // @ts-ignore since `getAuthenticatedHttpClient` is mocked.
     getAuthenticatedHttpClient.mockReturnValue({
       post: jest.fn().mockResolvedValue({ data: mockEmptyPermissions }),
     });
@@ -151,6 +157,7 @@ describe('useUserPermissions', () => {
   it('handles error when the API call fails', async () => {
     const mockError = new Error('API Error');
 
+    // @ts-ignore since `getAuthenticatedHttpClient` is mocked.
     getAuthenticatedHttpClient.mockReturnValue({
       post: jest.fn().mockRejectedValue(new Error('API Error')),
     });

src/authz/data/apiHooks.test.tsx

@@ -90,7 +90,7 @@ export function syncDiscussionsTopics(courseId: string) {
     try {
       await createDiscussionsTopics(courseId);
     } catch (error) {
-      logError(error);
+      logError(error as string | Error);
     }
   };
 }

src/course-outline/data/thunk.ts

@@ -56,9 +56,9 @@ const queryClient = new QueryClient();
 
 const renderComponent = (props?: Partial<LegacyStatusBarProps>) =>
   render(
-    <AppProvider store={store} messages={{}}>
+    <AppProvider store={store}>
       <QueryClientProvider client={queryClient}>
-        <IntlProvider locale="en">
+        <IntlProvider locale="en" messages={{}}>
           <LegacyStatusBar
             courseId={courseId}
             isLoading={isLoading}

src/course-outline/status-bar/LegacyStatusBar.test.tsx

@@ -1,12 +1,13 @@
-import { useEffect, useContext, useState } from 'react';
+import { useEffect, useState } from 'react';
 import {
   Routes,
   Route,
   useNavigate,
   Link,
 } from 'react-router-dom';
 import { useDispatch, useSelector } from 'react-redux';
-import { AppContext, PageWrap } from '@edx/frontend-platform/react';
+import { getConfig } from '@edx/frontend-platform';
+import { PageWrap } from '@edx/frontend-platform/react';
 import { useIntl, FormattedMessage } from '@edx/frontend-platform/i18n';
 import {
   ActionRow,
@@ -57,8 +58,7 @@ const CustomPages = () => {
 
   document.title = getPageHeadTitle(courseDetails?.name || '', intl.formatMessage(messages.heading));
 
-  // @ts-expect-error - frontend-platform doesn't have type information
-  const { config } = useContext(AppContext);
+  const config = getConfig();
   const learningCourseURL = `${config.LEARNING_BASE_URL}/course/${courseId}`;
 
   useEffect(() => {

src/custom-pages/CustomPages.tsx

@@ -34,6 +34,7 @@ const createWrapper = () => {
 describe('useValidateInputBlock', () => {
   beforeEach(() => {
     jest.clearAllMocks();
+    // @ts-ignore
     mockedGetConfig.mockReturnValue({
       STUDIO_BASE_URL: 'http://studio.local.openedx.io:8001',
     });

src/editors/containers/ProblemEditor/data/apiHooks.test.tsx

@@ -9,6 +9,7 @@ describe('cms service utils', () => {
   describe('get', () => {
     it('forwards arguments to authenticatedHttpClient().get', () => {
       const get = jest.fn((...args) => ({ get: args }));
+      // @ts-ignore since `getAuthenticatedHttpClient` is mocked.
       getAuthenticatedHttpClient.mockReturnValue({ get });
       const args = ['url 1', { headers: {} }] as const;
       expect(utils.get(...args)).toEqual(get(...args));
@@ -17,6 +18,7 @@ describe('cms service utils', () => {
   describe('post', () => {
     it('forwards arguments to authenticatedHttpClient().post', () => {
       const post = jest.fn((...args) => ({ post: args }));
+      // @ts-ignore since `getAuthenticatedHttpClient` is mocked.
       getAuthenticatedHttpClient.mockReturnValue({ post });
       const args = ['url 2', { headers: {} }] as const;
       expect(utils.post(...args)).toEqual(post(...args));