fix: Ensure compatibility with SQLAlchemy 1 (#13)

* fix: Ensure compatibility with SQLAlchemy 1

* Fix types

Author: edgarrmondragon

.github/workflows/test.yaml

@@ -49,11 +49,12 @@ jobs:
               hatch run typing:check
 
     test:
-        name: Pytest
+        name: Pytest (Python ${{ matrix.python-version }}, SQLAlchemy ${{ matrix.sqlalchemy-version }})
         runs-on: ubuntu-latest
         strategy:
             matrix:
                 python-version: ["3.8", "3.9", "3.10", "3.11"]
+                sqlalchemy-version: ["1", "2"]
         steps:
             - uses: actions/checkout@v3
             - uses: actions/setup-python@v4
@@ -66,6 +67,8 @@ jobs:
               run: |
                 pipx install hatch
             - name: Run tests
+              env:
+                SQLALCHEMY_VERSION: ${{ matrix.sqlalchemy-version }}
               run: |
                 hatch run test-cov
             - uses: actions/upload-artifact@v3

pyproject.toml

@@ -43,7 +43,7 @@ Source = "https://github.com/edgarrmondragon/sqlean-driver"
 source = "vcs"
 
 [tool.hatch.envs.default]
-dependencies = ["coverage[toml]>=6.5", "pytest"]
+dependencies = ["coverage[toml]>=6.5", "pytest", "sqlalchemy=={env:SQLALCHEMY_VERSION:1}.*"]
 [tool.hatch.envs.default.scripts]
 test = "pytest {args:tests}"
 test-cov = "coverage run -m pytest {args:tests}"

src/sqlean_driver/__init__.py

@@ -23,7 +23,7 @@ class SQLeanDialect(SQLiteDialect_pysqlite):
     supports_statement_cache = True
 
     @classmethod
-    def import_dbapi(cls: type[SQLeanDialect]) -> ModuleType:
+    def dbapi(cls: type[SQLeanDialect]) -> ModuleType:  # type: ignore[override]
         """Return the DBAPI module."""
         import sqlean
 
@@ -35,8 +35,8 @@ def on_connect_url(self: SQLeanDialect, url: URL) -> t.Callable[[t.Any], t.Any]
         extensions = query if isinstance(query, tuple) else query.split(",")
 
         if "all" in extensions:
-            self.dbapi.extensions.enable_all()  # type: ignore[union-attr]
+            self.dbapi.extensions.enable_all()  # type: ignore[attr-defined]
         else:
-            self.dbapi.extensions.enable(*extensions)  # type: ignore[union-attr]
+            self.dbapi.extensions.enable(*extensions)  # type: ignore[attr-defined]
 
         return super().on_connect_url(url)

tests/conftest.py

@@ -0,0 +1,10 @@
+"""Configuration for pytest."""
+
+from __future__ import annotations
+
+from sqlalchemy import __version__ as sqlalchemy_version
+
+
+def pytest_report_header() -> list[str]:
+    """Return a list of strings to be displayed in the header of the report."""
+    return [f"sqlalchemy: {sqlalchemy_version}"]