Update ESLint config to use flat config (#399)

* Fully convert to flat config

* Bump eslint plugin

* Fix eslint config

* Fix lint issues, remove lint target from e2e projects

Author: eddeee888

eslint.config.mjs

@@ -1,19 +1,27 @@
-import { FlatCompat } from '@eslint/eslintrc';
-import { dirname } from 'path';
-import { fileURLToPath } from 'url';
-import js from '@eslint/js';
-import nxEslintPlugin from '@nx/eslint-plugin';
+import { defineConfig } from 'eslint/config';
+import nx from '@nx/eslint-plugin';
+import my from '@eddeee888/eslint-plugin';
 
-const compat = new FlatCompat({
-  baseDirectory: dirname(fileURLToPath(import.meta.url)),
-  recommendedConfig: js.configs.recommended,
-});
-
-export default [
+export default defineConfig(
+  ...nx.configs['flat/base'],
+  ...nx.configs['flat/typescript'],
+  ...nx.configs['flat/javascript'],
+  ...my.configs.typescript,
   {
-    ignores: ['**/dist'],
+    languageOptions: {
+      parserOptions: {
+        projectService: true,
+      },
+    },
+  },
+  {
+    ignores: [
+      '**/dist',
+      'eslint.config.mjs',
+      'packages/typescript-resolver-files-e2e/src/**/*.generated.*',
+      'packages/typescript-resolver-files-e2e/src/**/*.gen.*',
+    ],
   },
-  { plugins: { '@nx': nxEslintPlugin } },
   {
     files: ['**/*.ts', '**/*.tsx', '**/*.js', '**/*.jsx'],
     rules: {
@@ -32,57 +40,12 @@ export default [
       ],
     },
   },
-  ...compat
-    .config({
-      extends: [
-        'plugin:@nx/typescript',
-        // FIXME: change to flat config
-        //'plugin:@eddeee888/typescript'
-      ],
-    })
-    .map((config) => ({
-      ...config,
-      files: ['**/*.ts', '**/*.tsx', '**/*.cts', '**/*.mts'],
-      rules: {
-        ...config.rules,
-      },
-    })),
-  ...compat
-    .config({
-      extends: ['plugin:@nx/javascript'],
-    })
-    .map((config) => ({
-      ...config,
-      files: ['**/*.js', '**/*.jsx', '**/*.cjs', '**/*.mjs'],
-      rules: {
-        ...config.rules,
-      },
-    })),
-  ...compat
-    .config({
-      env: {
-        jest: true,
-      },
-    })
-    .map((config) => ({
-      ...config,
-      files: ['**/*.spec.ts', '**/*.spec.tsx', '**/*.spec.js', '**/*.spec.jsx'],
-      rules: {
-        ...config.rules,
-      },
-    })),
   {
     files: ['**/*.json'],
     // Override or add rules here
     rules: {},
     languageOptions: {
       parser: await import('jsonc-eslint-parser'),
     },
-  },
-  {
-    ignores: [
-      'packages/typescript-resolver-files-e2e/src/**/*.generated.*',
-      'packages/typescript-resolver-files-e2e/src/**/*.gen.*',
-    ],
-  },
-];
+  }
+);

package.json

@@ -11,7 +11,7 @@
   },
   "devDependencies": {
     "@changesets/cli": "2.29.5",
-    "@eddeee888/eslint-plugin": "0.0.1",
+    "@eddeee888/eslint-plugin": "1.0.0",
     "@eddeee888/nx-graphql-code-generator": "2.0.0",
     "@eslint/eslintrc": "3.3.1",
     "@graphql-codegen/add": "6.0.0",

packages/operation-location-migration-e2e/eslint.config.mjs

@@ -128,9 +128,6 @@
         "parallel": false
       },
       "dependsOn": ["^build"]
-    },
-    "lint": {
-      "executor": "@nx/eslint:lint"
     }
   }
 }

packages/operation-location-migration-e2e/project.json

@@ -16,4 +16,7 @@ export default [
       parser: await import('jsonc-eslint-parser'),
     },
   },
+  {
+    ignores: ['**/out-tsc'],
+  },
 ];

packages/operation-location-migration/eslint.config.mjs

@@ -384,7 +384,7 @@ const createGqlTagImport = ({
   baseOutputDir: string;
   presetConfig: TypedPresetConfig;
   tsSourceFile: SourceFile;
-}) => {
+}): void => {
   const gqlTagModule =
     presetConfig.gqlTag.importType === 'absolute'
       ? presetConfig.gqlTag.importFrom
@@ -428,7 +428,7 @@ const createDoc = ({
   documentNodeName: string;
   documentSDL: string;
   exportDoc: boolean;
-}) => {
+}): void => {
   const importDeclarations = tsSourceFile.getImportDeclarations();
 
   // Find insertIndex, which is after the last import declaration

packages/operation-location-migration/src/preset.ts

@@ -1,46 +1,22 @@
-import { FlatCompat } from '@eslint/eslintrc';
-import { dirname } from 'path';
-import { fileURLToPath } from 'url';
-import js from '@eslint/js';
 import baseConfig from '../../eslint.config.mjs';
 
-const compat = new FlatCompat({
-  baseDirectory: dirname(fileURLToPath(import.meta.url)),
-  recommendedConfig: js.configs.recommended,
-});
-
 export default [
-  {
-    ignores: ['**/dist'],
-  },
   ...baseConfig,
-  {
-    files: ['**/*.ts', '**/*.tsx', '**/*.js', '**/*.jsx'],
-    // Override or add rules here
-    rules: {},
-  },
-  {
-    files: ['**/*.ts', '**/*.tsx'],
-    // Override or add rules here
-    rules: {},
-    languageOptions: {
-      parserOptions: {
-        project: ['packages/server-config/tsconfig(.*)?.json'],
-      },
-    },
-  },
-  {
-    files: ['**/*.js', '**/*.jsx'],
-    // Override or add rules here
-    rules: {},
-  },
   {
     files: ['**/*.json'],
     rules: {
-      '@nx/dependency-checks': 'error',
+      '@nx/dependency-checks': [
+        'error',
+        {
+          ignoredFiles: ['{projectRoot}/eslint.config.{js,cjs,mjs,ts,cts,mts}'],
+        },
+      ],
     },
     languageOptions: {
       parser: await import('jsonc-eslint-parser'),
     },
   },
+  {
+    ignores: ['**/out-tsc'],
+  },
 ];

packages/server-config/eslint.config.mjs

@@ -298,9 +298,6 @@
         "parallel": false
       },
       "dependsOn": ["^build"]
-    },
-    "lint": {
-      "executor": "@nx/eslint:lint"
     }
   }
 }

packages/typescript-resolver-files-e2e/eslint.config.mjs

@@ -1,2 +1,2 @@
 export { generateResolverFiles } from './generateResolverFiles';
-export * from './types';
+export type * from './types';