Fix static analysis not working due to different variations of assignments (#391)

* Set up e2e test

* Rebase e2e and handle more assignment cases

* Add changeset

Author: eddeee888

.changeset/funny-toes-turn.md

@@ -0,0 +1,5 @@
+---
+'@eddeee888/gcg-typescript-resolver-files': patch
+---
+
+Fix issue where shorthand assignment are not detected for static analysis

packages/typescript-resolver-files-e2e/src/test-mappers-vs-schema-types/modules/topic/Topic.name.ts

@@ -0,0 +1,5 @@
+import type { TopicResolvers } from '../types.generated';
+
+export const name: TopicResolvers['name'] = () => {
+  return 'Hot';
+};

packages/typescript-resolver-files-e2e/src/test-mappers-vs-schema-types/modules/topic/Topic.url.ts

@@ -0,0 +1,5 @@
+import type { TopicResolvers } from '../types.generated';
+
+export const Topic_url: TopicResolvers['url'] = () => {
+  return 'Hot';
+};

packages/typescript-resolver-files-e2e/src/test-mappers-vs-schema-types/modules/topic/resolvers/Topic.ts

@@ -1,18 +1,16 @@
 import type { TopicResolvers } from './../../types.generated';
+import { name } from '../Topic.name';
+import { Topic_url } from '../Topic.url';
 export const Topic: TopicResolvers = {
   id: ({ id }) => id,
   createdAt: async (_parent, _arg, _ctx) => {
     /* existing implementation, must keep */
     return '2024-01-01T00:00:00.000Z';
   },
+  name,
+  url: Topic_url,
   creator: ({ creator }, _arg, _ctx) => {
     /* Topic.creator resolver is required because Topic.creator and TopicMapper.creator are not compatible */
     return creator;
   },
-  name: async (_parent, _arg, _ctx) => {
-    /* Topic.name resolver is required because Topic.name exists but TopicMapper.name does not */
-  },
-  url: async (_parent, _arg, _ctx) => {
-    /* Topic.url resolver is required because Topic.url exists but TopicMapper.url does not */
-  },
 };

packages/typescript-resolver-files-e2e/src/test-mappers-vs-schema-types/testSetup.ts

@@ -7,12 +7,16 @@ createTestSetup({
     {
       file: 'modules/topic/resolvers/Topic.ts',
       content: `import type { TopicResolvers } from './../../types.generated';
+      import {name} from '../Topic.name';
+      import {Topic_url} from '../Topic.url';
       export const Topic: TopicResolvers = {
         id: ({ id }) => id,
         createdAt: async (_parent, _arg, _ctx) => {
           /* existing implementation, must keep */
           return '2024-01-01T00:00:00.000Z';
         },
+        name,
+        url: Topic_url,
       };`,
     },
   ],

packages/typescript-resolver-files/src/generateResolverFiles/addObjectTypeResolversPropertyAssignmentNodesIfNotImplemented.ts

@@ -56,6 +56,16 @@ export const addObjectTypeResolversPropertyAssignmentNodesIfNotImplemented = ({
     }
   > = { ...resolversToGenerate };
 
+  /**
+   * PropertyAssignment
+   * ```
+   * const name = () => {};
+   * const OutputType = {
+   *   id: () => {},
+   *   name: name,
+   * }
+   * ```
+   */
   variableStatement
     .getDescendantsOfKind(SyntaxKind.PropertyAssignment)
     .forEach((propertyAssignment) => {
@@ -65,6 +75,14 @@ export const addObjectTypeResolversPropertyAssignmentNodesIfNotImplemented = ({
       }
     });
 
+  /**
+   * MethodDeclaration
+   * ```
+   * const OutputType = {
+   *   id(){},
+   * }
+   * ```
+   */
   variableStatement
     .getDescendantsOfKind(SyntaxKind.MethodDeclaration)
     .forEach((methodDeclaration) => {
@@ -74,6 +92,24 @@ export const addObjectTypeResolversPropertyAssignmentNodesIfNotImplemented = ({
       }
     });
 
+  /**
+   * ShorthandPropertyAssignment example:
+   * ```
+   * const id = () => {};
+   * const OutputType = {
+   *   id,
+   * }
+   * ```
+   */
+  variableStatement
+    .getDescendantsOfKind(SyntaxKind.ShorthandPropertyAssignment)
+    .forEach((propertyAssignment) => {
+      const resolverName = propertyAssignment.getName();
+      if (resolversData[resolverName]) {
+        resolversData[resolverName].implemented = true;
+      }
+    });
+
   // 2. Add missing resolver properties if they haven't been implemented
   Object.values(resolversData).forEach(
     ({ resolverName, resolverDeclaration, implemented }) => {