Commit 8e484ef
committed
Redirect STDERR from help to /dev/null
On libreoffice > 4, the -h flag attempts to open the UI to display the
help, in addition to writing it to stdout.
This means that on Linux without X11 running, the output ends up looking like:
Failed to open display
LibreOffice 4.1.1.2 410m0(Build:2)
This behavior can be avoided by using the `--headless` flag, but that
flag isn't supported in older version of OpenOffice, causing an error
there.
Since Docsplit only looks at the first line of output it doesn't find
the version string, causing it to assume it should use OpenOffice in the
extract method. It then attempts to use the JOD convertor, which will
fail on recent versions of LibreOffice.
I believe this is the root cause of issue documentcloud#71 and should correct it.1 parent 8086ad3 commit 8e484ef
1 file changed
Lines changed: 6 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
0 commit comments