Skip to content

Commit 6827e63

Browse files
committed
merging package_names
1 parent 8f2a669 commit 6827e63

3 files changed

Lines changed: 5 additions & 13 deletions

File tree

lib/jammit.rb

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -186,11 +186,6 @@ def self.warn(message)
186186
message = "Jammit Warning: #{message}"
187187
$stderr.puts message
188188
end
189-
190-
def self.log(message)
191-
message = "Jammit: #{message}"
192-
$stdout.puts message
193-
end
194189

195190
# Clone of active_support's symbolize_keys, so that we don't have to depend
196191
# on active_support in any fashion. Converts a hash's keys to all symbols.

lib/jammit/command_line.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def parse_options
6464
@options[:force] = force
6565
end
6666
opts.on('-p', '--packages PACKAGE_NAMES', 'comma-separated list of packages (ex: "core,embed", default: all packages)') do |package_names|
67-
@options[:package_names] = package_names.split(',').map {|n| n.to_sym }
67+
@options[:package_names] = package_names.split(/,\s*/).map {|n| n.to_sym }
6868
end
6969
opts.on_tail('-v', '--version', 'display Jammit version') do
7070
puts "Jammit version #{Jammit::VERSION}"

lib/jammit/packager.rb

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ class Packager
1818
# Jammit.configuration. When assets.yml is being changed on the fly,
1919
# create a new Packager.
2020
def initialize
21-
@compressor = Compressor.new
22-
@force = false
23-
@package_names = nil
21+
@compressor = Compressor.new
22+
@force = false
23+
@package_names = nil
2424
@config = {
2525
:css => (Jammit.configuration[:stylesheets] || {}),
2626
:js => (Jammit.configuration[:javascripts] || {})
@@ -111,11 +111,8 @@ def glob_files(glob)
111111
# or whose source files have changed since the last package build.
112112
def cacheable(extension, output_dir)
113113
names = @packages[extension].keys
114+
names = names.select {|n| @package_names.include? n } if @package_names
114115
config_mtime = File.mtime(Jammit.config_path)
115-
if @package_names
116-
names = names.select {|n| @package_names.include? n }
117-
Jammit.log("Only packaging: #{names.inspect}")
118-
end
119116
return names if @force
120117
return names.select do |name|
121118
pack = package_for(name, extension)

0 commit comments

Comments
 (0)