Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Commit 0a0bc53

Browse files
authored
Merge pull request #1065 from gtardif/ci-compose-e2e
Ensure local compose E2E are run in CI.
2 parents 42acaea + 6d34f28 commit 0a0bc53

3 files changed

Lines changed: 5 additions & 6 deletions

File tree

Makefile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
# limitations under the License.
1414

1515
export DOCKER_BUILDKIT=1
16-
export BUILDX_NO_DEFAULT_LOAD=1
1716

1817
UNAME_S := $(shell uname -s)
1918
ifeq ($(UNAME_S),Linux)
@@ -45,10 +44,10 @@ cli: ## Compile the cli
4544
--output ./bin
4645

4746
e2e-local: ## Run End to end local tests. Set E2E_TEST=TestName to run a single test
48-
go test -count=1 -v $(TEST_FLAGS) ./tests/e2e ./tests/skip-win-ci-e2e ./local/e2e
47+
go test -count=1 -v $(TEST_FLAGS) ./tests/e2e ./tests/compose-e2e ./tests/skip-win-ci-e2e ./local/e2e
4948

5049
e2e-win-ci: ## Run end to end local tests on Windows CI, no Docker for Linux containers available ATM. Set E2E_TEST=TestName to run a single test
51-
go test -count=1 -v $(TEST_FLAGS) ./tests/e2e
50+
go test -count=1 -v $(TEST_FLAGS) ./tests/e2e ./tests/compose-e2e
5251

5352
e2e-aci: ## Run End to end ACI tests. Set E2E_TEST=TestName to run a single test
5453
go test -count=1 -v $(TEST_FLAGS) ./tests/aci-e2e

tests/compose-e2e/compose_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ func TestLocalComposeUp(t *testing.T) {
5757
res := c.RunDockerCmd("compose", "ps", "-p", projectName)
5858
res.Assert(t, icmd.Expected{Out: `web`})
5959

60-
endpoint := "http://localhost:80"
60+
endpoint := "http://localhost:90"
6161
output := HTTPGetWithRetry(t, endpoint+"/words/noun", http.StatusOK, 2*time.Second, 20*time.Second)
6262
assert.Assert(t, strings.Contains(output, `"word":`))
6363

tests/compose-e2e/fixtures/sentences/docker-compose.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ services:
44
words:
55
image: gtardif/sentences-api
66
ports:
7-
- "8080:8080"
7+
- "95:8080"
88
web:
99
image: gtardif/sentences-web
1010
ports:
11-
- "80:80"
11+
- "90:80"
1212
labels:
1313
- "my-label=test"

0 commit comments

Comments
 (0)