Skip to content
This repository was archived by the owner on Mar 22, 2018. It is now read-only.

Commit c819e2b

Browse files
author
Kubernetes Submit Queue
authored
Merge pull request #50206 from FengyunPan/add-debug
Automatic merge from submit-queue (batch tested with PRs 49524, 46760, 50206, 50166, 49603) [OpenStack] Add more detail error message I get same simple error messages "Unable to initialize cinder client for region: RegionOne" from controller-manager, but I can not find the reason. We should add more detail message "err" into glog.Errorf. Currently NewBlockStorageV2() return err when failed to get cinder endpoint, but there is no code to output the message of err. **Release note**: ```release-note NONE ```
2 parents ba4e874 + 68cecc1 commit c819e2b

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

pkg/cloudprovider/providers/openstack/openstack_client.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ func (os *OpenStack) NewNetworkV2() (*gophercloud.ServiceClient, error) {
2828
Region: os.region,
2929
})
3030
if err != nil {
31-
glog.Warningf("Failed to find network v2 endpoint: %v", err)
31+
glog.Warningf("Failed to find network v2 endpoint for region %s: %v", os.region, err)
3232
return nil, err
3333
}
3434
return network, nil
@@ -39,7 +39,7 @@ func (os *OpenStack) NewComputeV2() (*gophercloud.ServiceClient, error) {
3939
Region: os.region,
4040
})
4141
if err != nil {
42-
glog.Warningf("Failed to find compute v2 endpoint: %v", err)
42+
glog.Warningf("Failed to find compute v2 endpoint for region %s: %v", os.region, err)
4343
return nil, err
4444
}
4545
return compute, nil
@@ -50,7 +50,7 @@ func (os *OpenStack) NewBlockStorageV1() (*gophercloud.ServiceClient, error) {
5050
Region: os.region,
5151
})
5252
if err != nil {
53-
glog.Errorf("Unable to initialize cinder v1 client for region: %s", os.region)
53+
glog.Errorf("Unable to initialize cinder v1 client for region %s: %v", os.region, err)
5454
return nil, err
5555
}
5656
return storage, nil
@@ -61,7 +61,7 @@ func (os *OpenStack) NewBlockStorageV2() (*gophercloud.ServiceClient, error) {
6161
Region: os.region,
6262
})
6363
if err != nil {
64-
glog.Errorf("Unable to initialize cinder v2 client for region: %s", os.region)
64+
glog.Errorf("Unable to initialize cinder v2 client for region %s: %v", os.region, err)
6565
return nil, err
6666
}
6767
return storage, nil

0 commit comments

Comments
 (0)