Skip to content
This repository was archived by the owner on Mar 22, 2018. It is now read-only.

Commit 9fad374

Browse files
author
Kubernetes Submit Queue
authored
Merge pull request #56820 from ixdy/pure-go-binaries
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump rules_go and build "static" binaries in pure Go mode **What this PR does / why we need it**: uses latest set of enhancements in bazelbuild/rules_go to properly build the "static" Go binaries using pure Go (i.e. `CGO_ENABLED=0`), and to support cross compilation of these binaries. Cross compilation of cgo-enabled binaries is still not supported. Also depends on kubernetes/repo-infra#52, and requires bazel 0.8+ (which is not yet enabled in CI for kubernetes/kubernetes). Note that for proper cross compilation we'll also need to remove the hardcoded "linux-amd64" that's strewn about several `BUILD` files. **Release note**: ```release-note NONE ``` /hold /assign @BenTheElder @mikedanese @spxtr
2 parents 69dbea4 + 346471f commit 9fad374

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

  • pkg
    • cloudprovider/providers/openstack
    • volume/cinder
  • staging/src/k8s.io/client-go/plugin/pkg/client/auth/openstack

pkg/cloudprovider/providers/openstack/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ go_test(
7272
"openstack_routes_test.go",
7373
"openstack_test.go",
7474
],
75+
embed = [":go_default_library"],
7576
importpath = "k8s.io/kubernetes/pkg/cloudprovider/providers/openstack",
76-
library = ":go_default_library",
7777
deps = [
7878
"//pkg/cloudprovider:go_default_library",
7979
"//vendor/github.com/gophercloud/gophercloud:go_default_library",

pkg/volume/cinder/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ go_test(
4343
"attacher_test.go",
4444
"cinder_test.go",
4545
],
46+
embed = [":go_default_library"],
4647
importpath = "k8s.io/kubernetes/pkg/volume/cinder",
47-
library = ":go_default_library",
4848
deps = [
4949
"//pkg/cloudprovider:go_default_library",
5050
"//pkg/util/mount:go_default_library",

staging/src/k8s.io/client-go/plugin/pkg/client/auth/openstack/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ load(
99
go_test(
1010
name = "go_default_test",
1111
srcs = ["openstack_test.go"],
12+
embed = [":go_default_library"],
1213
importpath = "k8s.io/client-go/plugin/pkg/client/auth/openstack",
13-
library = ":go_default_library",
1414
)
1515

1616
go_library(

0 commit comments

Comments
 (0)