Add some unit tests & improve logging

Author: chakri-nelluri

app/cinderplugin/main.go

@@ -17,6 +17,7 @@ limitations under the License.
 package main
 
 import (
+	"flag"
 	"fmt"
 	"os"
 
@@ -30,7 +31,14 @@ var (
 	cloudconfig string
 )
 
+func init() {
+	flag.Set("logtostderr", "true")
+}
+
 func main() {
+
+	flag.CommandLine.Parse([]string{})
+
 	cmd := &cobra.Command{
 		Use:   "Cinder",
 		Short: "CSI based Cinder driver",
@@ -39,6 +47,8 @@ func main() {
 		},
 	}
 
+	cmd.Flags().AddGoFlagSet(flag.CommandLine)
+
 	cmd.PersistentFlags().StringVar(&nodeID, "nodeid", "", "node id")
 	cmd.MarkPersistentFlagRequired("nodeid")
 

pkg/cinder/mount/mount.go

@@ -25,13 +25,13 @@ import (
 	"k8s.io/kubernetes/pkg/util/mount"
 	"k8s.io/kubernetes/pkg/volume/util"
 	utilexec "k8s.io/utils/exec"
-	
+
 	"github.com/golang/glog"
 )
 
 const (
-	probeVolumeDuration      = 1 * time.Second
-	probeVolumeTimeout       = 60 * time.Second
+	probeVolumeDuration = 1 * time.Second
+	probeVolumeTimeout  = 60 * time.Second
 )
 
 type IMount interface {
@@ -129,11 +129,11 @@ func (m *Mount) IsLikelyNotMountPointDetach(targetpath string) (bool, error) {
 	notMnt, err := mount.New("").IsLikelyNotMountPoint(targetpath)
 	if err != nil {
 		if os.IsNotExist(err) {
- 			return notMnt,fmt.Errorf("targetpath not found")
- 		} else {
- 			return notMnt, err
- 		}
- 	}
+			return notMnt, fmt.Errorf("targetpath not found")
+		} else {
+			return notMnt, err
+		}
+	}
 	return notMnt, nil
 }
 

pkg/cinder/nodeserver.go

@@ -36,14 +36,14 @@ func (ns *nodeServer) NodePublishVolume(ctx context.Context, req *csi.NodePublis
 	targetPath := req.GetTargetPath()
 	fsType := req.GetVolumeCapability().GetMount().GetFsType()
 	devicePath := req.GetPublishVolumeInfo()["DevicePath"]
-	
+
 	// Get Mount Provider
 	m, err := mount.GetMountProvider()
 	if err != nil {
 		glog.V(3).Infof("Failed to GetMountProvider: %v", err)
 		return nil, err
 	}
-	
+
 	// Device Scan
 	err = m.ScanForAttach(devicePath)
 	if err != nil {
@@ -68,7 +68,7 @@ func (ns *nodeServer) NodePublishVolume(ctx context.Context, req *csi.NodePublis
 		}
 		mountFlags := req.GetVolumeCapability().GetMount().GetMountFlags()
 		options = append(options, mountFlags...)
-		
+
 		// Mount
 		err = m.FormatAndMount(devicePath, targetPath, fsType, options)
 		if err != nil {
@@ -82,7 +82,7 @@ func (ns *nodeServer) NodePublishVolume(ctx context.Context, req *csi.NodePublis
 func (ns *nodeServer) NodeUnpublishVolume(ctx context.Context, req *csi.NodeUnpublishVolumeRequest) (*csi.NodeUnpublishVolumeResponse, error) {
 
 	targetPath := req.GetTargetPath()
-	
+
 	// Get Mount Provider
 	m, err := mount.GetMountProvider()
 	if err != nil {

pkg/cinder/openstack/openstack.go

@@ -105,7 +105,7 @@ func GetConfigFromEnv() (gophercloud.AuthOptions, gophercloud.EndpointOpts, erro
 		glog.V(3).Infof("Failed to read OpenStack configuration from env: %v", err)
 		return authOpts, epOpts, err
 	}
-	
+
 	epOpts = gophercloud.EndpointOpts{
 		Region: os.Getenv("OS_REGION_NAME"),
 	}