remove unnecessary condition judgement

stewart-yu · stewart-yu · commit 8b4aa25278dc · 2017-12-01T15:15:31.000+08:00
diff --git a/pkg/cloudprovider/providers/openstack/openstack_loadbalancer.go b/pkg/cloudprovider/providers/openstack/openstack_loadbalancer.go
@@ -1287,7 +1287,7 @@ func (lbaas *LbaasV2) EnsureLoadBalancerDeleted(clusterName string, service *v1.
 		return nil
 	}
 
-	if loadbalancer != nil && loadbalancer.VipPortID != "" {
+	if loadbalancer.VipPortID != "" {
 		portID := loadbalancer.VipPortID
 		floatingIP, err := getFloatingIPByPortID(lbaas.network, portID)
 		if err != nil && err != ErrNotFound {

Original file line number	Diff line number	Diff line change
`@@ -1287,7 +1287,7 @@ func (lbaas LbaasV2) EnsureLoadBalancerDeleted(clusterName string, service v1.`
`1287`	`1287`	`return nil`
`1288`	`1288`	`}`
`1289`	`1289`
`1290`		`- if loadbalancer != nil && loadbalancer.VipPortID != "" {`
	`1290`	`+ if loadbalancer.VipPortID != "" {`
`1291`	`1291`	`portID := loadbalancer.VipPortID`
`1292`	`1292`	`floatingIP, err := getFloatingIPByPortID(lbaas.network, portID)`
`1293`	`1293`	`if err != nil && err != ErrNotFound {`