Use custom error for "unimplemented"

Henrik Schmidt · Henrik Schmidt · commit 617710250980 · 2017-09-26T09:21:53.000+02:00
diff --git a/pkg/cloudprovider/providers/openstack/openstack_instances.go b/pkg/cloudprovider/providers/openstack/openstack_instances.go
@@ -17,7 +17,6 @@ limitations under the License.
 package openstack
 
 import (
-	"errors"
 	"fmt"
 	"regexp"
 
@@ -59,7 +58,7 @@ func (i *Instances) CurrentNodeName(hostname string) (types.NodeName, error) {
 }
 
 func (i *Instances) AddSSHKeyToAllInstances(user string, keyData []byte) error {
-	return errors.New("unimplemented")
+	return cloudprovider.NotImplemented
 }
 
 func (i *Instances) NodeAddresses(name types.NodeName) ([]v1.NodeAddress, error) {
@@ -113,7 +112,7 @@ func (i *Instances) ExternalID(name types.NodeName) (string, error) {
 // InstanceExistsByProviderID returns true if the instance with the given provider id still exists and is running.
 // If false is returned with no error, the instance will be immediately deleted by the cloud controller manager.
 func (i *Instances) InstanceExistsByProviderID(providerID string) (bool, error) {
-	return false, errors.New("unimplemented")
+	return false, cloudprovider.NotImplemented
 }
 
 // InstanceID returns the kubelet's cloud provider ID.

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@ limitations under the License.`
`17`	`17`	`package openstack`
`18`	`18`
`19`	`19`	`import (`
`20`		`- "errors"`
`21`	`20`	`"fmt"`
`22`	`21`	`"regexp"`
`23`	`22`
`@@ -59,7 +58,7 @@ func (i *Instances) CurrentNodeName(hostname string) (types.NodeName, error) {`
`59`	`58`	`}`
`60`	`59`
`61`	`60`	`func (i *Instances) AddSSHKeyToAllInstances(user string, keyData []byte) error {`
`62`		`- return errors.New("unimplemented")`
	`61`	`+ return cloudprovider.NotImplemented`
`63`	`62`	`}`
`64`	`63`
`65`	`64`	`func (i *Instances) NodeAddresses(name types.NodeName) ([]v1.NodeAddress, error) {`
`@@ -113,7 +112,7 @@ func (i *Instances) ExternalID(name types.NodeName) (string, error) {`
`113`	`112`	`// InstanceExistsByProviderID returns true if the instance with the given provider id still exists and is running.`
`114`	`113`	`// If false is returned with no error, the instance will be immediately deleted by the cloud controller manager.`
`115`	`114`	`func (i *Instances) InstanceExistsByProviderID(providerID string) (bool, error) {`
`116`		`- return false, errors.New("unimplemented")`
	`115`	`+ return false, cloudprovider.NotImplemented`
`117`	`116`	`}`
`118`	`117`
`119`	`118`	`// InstanceID returns the kubelet's cloud provider ID.`