Skip to content
This repository was archived by the owner on Mar 22, 2018. It is now read-only.

Commit 6119229

Browse files
author
Kubernetes Submit Queue
authored
Merge pull request #50776 from kevin-wangzefeng/core-to-corev1-round2
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Use the core client with explicit version globally **What this PR does / why we need it**: As mentioned in #49535 and #50605, we want to have a global replace to use core client with explicit version. **Which issue this PR fixes**: fixes #49535 **Special notes for your reviewer**: The actual type of clientSet.Core() is already the same with clientSet.CoreV1(), so it should be safe replacement. The places that clientSet.Core() are still in use are identified by IDE "find usages", and changes are made with one time global replace. Hopefully there will be none left after this PR merged. Let me know if this PR is too big to review, I can split it into some smaller ones. /cc @kubernetes/sig-api-machinery-pr-reviews /cc @k82cn @sttts **Release note**: ```release-note none ```
2 parents 5cab8c1 + a4eecf5 commit 6119229

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

pkg/volume/cinder/cinder_util.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ func getZonesFromNodes(kubeClient clientset.Interface) (sets.String, error) {
144144
// TODO: caching, currently it is overkill because it calls this function
145145
// only when it creates dynamic PV
146146
zones := make(sets.String)
147-
nodes, err := kubeClient.Core().Nodes().List(metav1.ListOptions{})
147+
nodes, err := kubeClient.CoreV1().Nodes().List(metav1.ListOptions{})
148148
if err != nil {
149149
glog.V(2).Infof("Error listing nodes")
150150
return zones, err

0 commit comments

Comments
 (0)