Skip to content
This repository was archived by the owner on Mar 22, 2018. It is now read-only.

Commit 3162622

Browse files
author
FengyunPan
committed
Mark the LBaaS v1 of OpenStack cloud provider deprecated
Since LBaaS v1 is deprecated in the OpenStack Liberty release, we deprecated it on Kubernetes. Reference OpenStack doc: https://docs.openstack.org/mitaka/networking-guide/config-lbaas.html Related to: #52717
1 parent f85051a commit 3162622

2 files changed

Lines changed: 5 additions & 0 deletions

File tree

pkg/cloudprovider/providers/openstack/openstack.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -520,6 +520,9 @@ func (os *OpenStack) LoadBalancer() (cloudprovider.LoadBalancer, bool) {
520520
if lbVersion == "v2" {
521521
return &LbaasV2{LoadBalancer{network, compute, os.lbOpts}}, true
522522
} else if lbVersion == "v1" {
523+
// Since LBaaS v1 is deprecated in the OpenStack Liberty release, so deprecate LBaaSV1 at V1.8, then remove LBaaSV1 after V1.9.
524+
// Reference OpenStack doc: https://docs.openstack.org/mitaka/networking-guide/config-lbaas.html
525+
glog.Warningf("The LBaaS v1 of OpenStack cloud provider has been deprecated, Please use LBaaS v2")
523526
return &LbaasV1{LoadBalancer{network, compute, os.lbOpts}}, true
524527
} else {
525528
glog.Warningf("Config error: unrecognised lb-version \"%v\"", lbVersion)

pkg/cloudprovider/providers/openstack/openstack_loadbalancer.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,8 @@ const (
7575
ServiceAnnotationLoadBalancerInternal = "service.beta.kubernetes.io/openstack-internal-load-balancer"
7676
)
7777

78+
// Deprecated; Since LBaaS v1 is deprecated in the OpenStack Liberty release, Kubernetes deprecated it at V1.8.
79+
// TODO(FengyunPan): remove LBaaS v1 after kubernetes V1.9.
7880
// LoadBalancer implementation for LBaaS v1
7981
type LbaasV1 struct {
8082
LoadBalancer

0 commit comments

Comments
 (0)