Skip to content
This repository was archived by the owner on Mar 22, 2018. It is now read-only.

Commit 1ccea30

Browse files
committed
Rename Detach() parameter.
Detach() does not get device name, it gets volume name.
1 parent 3cb72bd commit 1ccea30

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

pkg/volume/cinder/attacher.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -374,8 +374,8 @@ func (detacher *cinderDiskDetacher) waitDiskDetached(instanceID, volumeID string
374374
return err
375375
}
376376

377-
func (detacher *cinderDiskDetacher) Detach(deviceMountPath string, nodeName types.NodeName) error {
378-
volumeID := path.Base(deviceMountPath)
377+
func (detacher *cinderDiskDetacher) Detach(volumeName string, nodeName types.NodeName) error {
378+
volumeID := path.Base(volumeName)
379379
instances, res := detacher.cinderProvider.Instances()
380380
if !res {
381381
return fmt.Errorf("failed to list openstack instances")

0 commit comments

Comments
 (0)