Skip to content
This repository was archived by the owner on Mar 22, 2018. It is now read-only.

Commit 1c34b0a

Browse files
author
Kubernetes Submit Queue
authored
Merge pull request #50407 from ixdy/gazelle-and-kazel
Automatic merge from submit-queue (batch tested with PRs 49488, 50407, 46105, 50456, 50258) Manage BUILD files using gazelle + kazel **What this PR does / why we need it**: uses the upstream `gazelle` tool to manage go rules in BUILD files. This is needed to support Bazel builds on Mac OS and Bazel cross compilation in general. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #47558 **Special notes for your reviewer**: It's probably easiest to review this commit-by-commit: * bump to latest `rules_go` (for recent `cgo_library` and `gazelle` improvements) * update `kazel` with recent compatibility fixes (kubernetes/repo-infra#28, kubernetes/repo-infra#27), update `hack` scripts to download/build `gazelle`, and then run both `gazelle` and `kazel`. (Additionally make `gazelle` skip things it shouldn't touch.) * run `hack/update-bazel.sh` to autogenerate everything * remove the old `cgo_genrule` rules - these are now part of `go_library` * remove the `automanaged` tags from all go rules - `gazelle` doesn't use them, and it prevents an old version of `kazel/gazel` from messing with the rules * remove the `licenses()` rules from everywhere but `third_party/` - we don't need them, and `gazelle` won't add them on new `BUILD` files it generates. **Release note**: ```release-note NONE ``` for review: /assign @mikedanese @spxtr for approval: /assign @thockin
2 parents 769e362 + 4136ae3 commit 1c34b0a

3 files changed

Lines changed: 0 additions & 12 deletions

File tree

  • pkg
    • cloudprovider/providers/openstack
    • volume/cinder
  • staging/src/k8s.io/client-go/plugin/pkg/client/auth/openstack

pkg/cloudprovider/providers/openstack/BUILD

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
licenses(["notice"])
4-
53
load(
64
"@io_bazel_rules_go//go:def.bzl",
75
"go_library",
@@ -20,7 +18,6 @@ go_library(
2018
"openstack_routes.go",
2119
"openstack_volumes.go",
2220
],
23-
tags = ["automanaged"],
2421
deps = [
2522
"//pkg/api/v1/helper:go_default_library",
2623
"//pkg/api/v1/service:go_default_library",
@@ -73,7 +70,6 @@ go_test(
7370
"openstack_test.go",
7471
],
7572
library = ":go_default_library",
76-
tags = ["automanaged"],
7773
deps = [
7874
"//pkg/cloudprovider:go_default_library",
7975
"//vendor/github.com/gophercloud/gophercloud:go_default_library",

pkg/volume/cinder/BUILD

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
licenses(["notice"])
4-
53
load(
64
"@io_bazel_rules_go//go:def.bzl",
75
"go_library",
@@ -16,7 +14,6 @@ go_library(
1614
"cinder_util.go",
1715
"doc.go",
1816
],
19-
tags = ["automanaged"],
2017
deps = [
2118
"//pkg/cloudprovider:go_default_library",
2219
"//pkg/cloudprovider/providers/openstack:go_default_library",
@@ -47,7 +44,6 @@ go_test(
4744
"cinder_test.go",
4845
],
4946
library = ":go_default_library",
50-
tags = ["automanaged"],
5147
deps = [
5248
"//pkg/cloudprovider:go_default_library",
5349
"//pkg/util/mount:go_default_library",

staging/src/k8s.io/client-go/plugin/pkg/client/auth/openstack/BUILD

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package(default_visibility = ["//visibility:public"])
22

3-
licenses(["notice"])
4-
53
load(
64
"@io_bazel_rules_go//go:def.bzl",
75
"go_library",
@@ -12,13 +10,11 @@ go_test(
1210
name = "go_default_test",
1311
srcs = ["openstack_test.go"],
1412
library = ":go_default_library",
15-
tags = ["automanaged"],
1613
)
1714

1815
go_library(
1916
name = "go_default_library",
2017
srcs = ["openstack.go"],
21-
tags = ["automanaged"],
2218
deps = [
2319
"//vendor/github.com/golang/glog:go_default_library",
2420
"//vendor/github.com/gophercloud/gophercloud/openstack:go_default_library",

0 commit comments

Comments
 (0)