Skip to content

Commit faafdae

Browse files
Increment running count "manually" to avoid future closer count mismatches
1 parent d1446ad commit faafdae

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

dgraph/cmd/zero/raft.go

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -879,17 +879,25 @@ func (n *node) Run() {
879879
// snapshot can cause select loop to block while deleting entries, so run
880880
// it in goroutine
881881
readStateCh := make(chan raft.ReadState, 100)
882-
closer := z.NewCloser(4)
882+
closer := z.NewCloser(0)
883883
defer func() {
884884
closer.SignalAndWait()
885885
n.closer.Done()
886886
glog.Infof("Zero Node.Run finished.")
887887
}()
888888

889+
closer.AddRunning(1)
889890
go n.snapshotPeriodically(closer)
891+
892+
closer.AddRunning(1)
890893
go n.updateZeroMembershipPeriodically(closer)
894+
895+
closer.AddRunning(1)
891896
go n.checkQuorum(closer)
897+
898+
closer.AddRunning(1)
892899
go n.RunReadIndexLoop(closer, readStateCh)
900+
893901
if !x.WorkerConfig.HardSync {
894902
closer.AddRunning(1)
895903
go x.StoreSync(n.Store, closer)

0 commit comments

Comments
 (0)