Skip to content

Commit f98cfaf

Browse files
ShivaShiva
authored andcommitted
Unskip previously skipped tests
1 parent f48a893 commit f98cfaf

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

dgraph/cmd/dgraphimport/import_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ func TestEmptyBulkOutDir(t *testing.T) {
7575
}
7676

7777
func TestDrainModeAfterStartSnapshotStream(t *testing.T) {
78-
t.Skip("Skipping... sometimes the query for schema succeeds even when the server is in draining mode")
78+
// t.Skip("Skipping... sometimes the query for schema succeeds even when the server is in draining mode")
7979

8080
tests := []struct {
8181
name string
@@ -123,7 +123,7 @@ func TestDrainModeAfterStartSnapshotStream(t *testing.T) {
123123
}
124124

125125
func TestImportApis(t *testing.T) {
126-
t.Skip("Skipping import tests due to persistent flakiness with container networking and Raft leadership issues")
126+
// t.Skip("Skipping import tests due to persistent flakiness with container networking and Raft leadership issues")
127127

128128
tests := []testcase{
129129
{
@@ -412,6 +412,7 @@ func verifyImportResults(t *testing.T, gc *dgraphapi.GrpcClient, downAlphas int)
412412
// Get actual predicates
413413
actualPredicates := getPredicateMap(actualSchema)
414414

415+
hasAllPredicates := true
415416
// Check if all expected predicates are present
416417
for predName := range expectedPredicates {
417418
if _, exists := actualPredicates[predName]; !exists {

dgraphtest/load.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -580,8 +580,8 @@ func downloadFile(fname, url string) error {
580580
cmd := exec.Command("wget", "-O", fname, url)
581581
cmd.Dir = datasetFilesPath
582582

583-
if out, err := cmd.CombinedOutput(); err != nil {
584-
return fmt.Errorf("error downloading file %s: %s", fname, string(out))
583+
if _, err := cmd.CombinedOutput(); err != nil {
584+
return fmt.Errorf("error downloading file %s: %w", fname, err)
585585
}
586586
return nil
587587
}

dgraphtest/local_cluster.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -930,8 +930,7 @@ func (c *LocalCluster) Client() (*dgraphapi.GrpcClient, func(), error) {
930930
var conns []*grpc.ClientConn
931931
for _, aa := range c.alphas {
932932
if !aa.isRunning {
933-
// QUESTIONS(shivaji): Should this be 'continue' instead of a break from the loop
934-
break
933+
continue
935934
}
936935
url, err := aa.alphaURL(c)
937936
if err != nil {

0 commit comments

Comments
 (0)