Skip to content

Commit e01d0a1

Browse files
fixed trunk stuff
1 parent 44a13cb commit e01d0a1

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

dgraph/cmd/zero/zero.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@ func (s *Server) Inform(ctx context.Context, req *pb.TabletRequest) (*pb.TabletR
443443
}
444444

445445
if err := s.Node.proposeAndWait(ctx, &proposal); err != nil && err != errTabletAlreadyServed {
446-
span.AddEvent(fmt.Sprintf("Error proposing tablet: %+v. Error: %v", proposal, err))
446+
span.AddEvent(fmt.Sprintf("Error proposing tablet: %+v. Error: %v", &proposal, err))
447447
return nil, err
448448
}
449449

@@ -698,7 +698,7 @@ func (s *Server) ShouldServe(
698698
}
699699
proposal.Tablet = tablet
700700
if err := s.Node.proposeAndWait(ctx, &proposal); err != nil && err != errTabletAlreadyServed {
701-
span.AddEvent(fmt.Sprintf("Error proposing tablet: %+v. Error: %v", proposal, err))
701+
span.AddEvent(fmt.Sprintf("Error proposing tablet: %+v. Error: %v", &proposal, err))
702702
return tablet, err
703703
}
704704
tab = s.ServingTablet(tablet.Predicate)

x/metrics.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ var (
440440
}
441441
)
442442

443-
func startTracing() (*traceTel.TracerProvider, error) {
443+
func startTracing() {
444444
headers := map[string]string{
445445
"content-type": "application/json",
446446
}
@@ -454,7 +454,7 @@ func startTracing() (*traceTel.TracerProvider, error) {
454454
),
455455
)
456456
if err != nil {
457-
return nil, fmt.Errorf("creating new exporter: %w", err)
457+
glog.Errorf("creating new exporter: %v", err)
458458
}
459459

460460
tracerprovider := traceTel.NewTracerProvider(
@@ -473,8 +473,6 @@ func startTracing() (*traceTel.TracerProvider, error) {
473473
)
474474

475475
otel.SetTracerProvider(tracerprovider)
476-
477-
return tracerprovider, nil
478476
}
479477

480478
func init() {

0 commit comments

Comments
 (0)