fixed reviews

Author: darkcoderrises

dgraph/cmd/zero/oracle.go

@@ -1,5 +1,5 @@
 /*
- * SPDX-FileCopyrightText:  Hypermode Inc. <[email protected]>
+ * SPDX-FileCopyrightText: © Hypermode Inc. <[email protected]>
  * SPDX-License-Identifier: Apache-2.0
  */
 
@@ -505,8 +505,7 @@ func (s *Server) Timestamps(ctx context.Context, num *pb.Num) (*pb.AssignedIds,
 
 	num.Type = pb.Num_TXN_TS
 	reply, err := s.lease(ctx, num)
-	span.SetAttributes(attribute.String("response", fmt.Sprintf("%+v", reply)))
-	span.SetAttributes(attribute.String("error", fmt.Sprintf("%v", err)))
+	span.AddEvent(fmt.Sprintf("Response: %+v, Error: %+v", reply, err))
 
 	switch err {
 	case nil:

dgraph/cmd/zero/raft.go

@@ -1,5 +1,5 @@
 /*
- * SPDX-FileCopyrightText:  Hypermode Inc. <[email protected]>
+ * SPDX-FileCopyrightText: © Hypermode Inc. <[email protected]>
  * SPDX-License-Identifier: Apache-2.0
  */
 
@@ -1013,8 +1013,6 @@ func (n *node) Run() {
 			span.AddEvent("Advanced Raft")
 			timer.Record("advance")
 
-			span.SetAttributes(attribute.String("Zero.RunLoop", "Running"))
-			span.SetAttributes(attribute.String("Zero.RunLoop", "Done"))
 			span.End()
 			if timer.Total() > 5*tickDur {
 				glog.Warningf(

dgraph/cmd/zero/run.go

@@ -1,5 +1,5 @@
 /*
- * SPDX-FileCopyrightText:  Hypermode Inc. <[email protected]>
+ * SPDX-FileCopyrightText: © Hypermode Inc. <[email protected]>
  * SPDX-License-Identifier: Apache-2.0
  */
 

edgraph/server.go

@@ -1440,15 +1440,13 @@ func processQuery(ctx context.Context, qc *queryContext) (*api.Response, error)
 	// Here we try our best effort to not contact Zero for a timestamp. If we succeed,
 	// then we use the max known transaction ts value (from ProcessDelta) for a read-only query.
 	// If we haven't processed any updates yet then fall back to getting TS from Zero.
-	if qc.span.IsRecording() {
-		switch {
-		case qc.req.BestEffort:
-			qc.span.AddEvent("", trace.WithAttributes(attribute.Bool("be", true)))
-		case qc.req.ReadOnly:
-			qc.span.AddEvent("", trace.WithAttributes(attribute.Bool("ro", true)))
-		default:
-			qc.span.AddEvent("", trace.WithAttributes(attribute.Bool("no", true)))
-		}
+	switch {
+	case qc.req.BestEffort:
+		qc.span.AddEvent("", trace.WithAttributes(attribute.Bool("be", true)))
+	case qc.req.ReadOnly:
+		qc.span.AddEvent("", trace.WithAttributes(attribute.Bool("ro", true)))
+	default:
+		qc.span.AddEvent("", trace.WithAttributes(attribute.Bool("no", true)))
 	}
 
 	if qc.req.BestEffort {

go.mod

@@ -1,8 +1,6 @@
 module github.com/hypermodeinc/dgraph/v24
 
-go 1.23.0
-
-toolchain go1.24.1
+go 1.23.6
 
 require (
 	contrib.go.opencensus.io/exporter/prometheus v0.4.2