Skip to content

Commit a17fc6b

Browse files
authored
Fix bugs in v25 RunDQL API (#9388)
1 parent 25f6019 commit a17fc6b

1 file changed

Lines changed: 11 additions & 8 deletions

File tree

edgraph/query.go

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,22 +34,25 @@ func (s *ServerV25) RunDQL(ctx context.Context, req *apiv25.RunDQLRequest) (*api
3434
"v25.RunDQL can only be called by the guardian of the galaxy. "+s.Message())
3535
}
3636

37-
apiReq, err := dql.ParseDQL(req.DqlQuery)
37+
nsID, err := getNamespaceIDFromName(x.AttachJWTNamespace(ctx), req.NsName)
3838
if err != nil {
39-
return nil, fmt.Errorf("error parsing DQL query: %w", err)
39+
return nil, fmt.Errorf("error retrieving namespace ID: %w", err)
4040
}
4141

42-
nsID, err := getNamespaceIDFromName(x.AttachJWTNamespace(ctx), req.NsName)
42+
apiReq, err := dql.ParseDQL(req.DqlQuery)
4343
if err != nil {
44-
return nil, err
44+
return nil, fmt.Errorf("error parsing DQL query: %w", err)
4545
}
4646

47+
apiReq.Vars = req.Vars
48+
apiReq.ReadOnly = req.ReadOnly
49+
apiReq.BestEffort = req.BestEffort
50+
apiReq.RespFormat = api.Request_JSON
51+
if req.RespFormat == apiv25.RespFormat_RDF {
52+
apiReq.RespFormat = api.Request_RDF
53+
}
4754
if len(apiReq.Mutations) > 0 {
4855
apiReq.CommitNow = true
49-
apiReq.Vars = req.Vars
50-
apiReq.ReadOnly = req.ReadOnly
51-
apiReq.BestEffort = req.BestEffort
52-
apiReq.RespFormat = api.Request_RespFormat(req.RespFormat)
5356
}
5457

5558
apiResp, err := (&Server{}).doQuery(x.AttachNamespace(ctx, nsID),

0 commit comments

Comments
 (0)