fix(bm25): clamp startPos in skipTo to prevent negative sort.Search length

shaunpatterson · claude · shaunpatterson · commit 9093cb001375 · 2026-03-05T09:10:29.000-05:00
Defensive hardening from GPT-5 review: if inBlockPos exceeds block length
after next() reaches end of block, the sort.Search span could go negative.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/worker/bm25wand.go b/worker/bm25wand.go
@@ -188,6 +188,8 @@ func (it *listIter) skipTo(target uint64) bool {
 			startPos := it.inBlockPos
 			if startPos < 0 {
 				startPos = 0
+			} else if startPos > len(it.block) {
+				startPos = len(it.block)
 			}
 			// Binary search within current block from startPos.
 			pos := sort.Search(len(it.block)-startPos, func(i int) bool {

Original file line number	Diff line number	Diff line change
`@@ -188,6 +188,8 @@ func (it *listIter) skipTo(target uint64) bool {`
`188`	`188`	`startPos := it.inBlockPos`
`189`	`189`	`if startPos < 0 {`
`190`	`190`	`startPos = 0`
	`191`	`+ } else if startPos > len(it.block) {`
	`192`	`+ startPos = len(it.block)`
`191`	`193`	`}`
`192`	`194`	`// Binary search within current block from startPos.`
`193`	`195`	`pos := sort.Search(len(it.block)-startPos, func(i int) bool {`