Skip to content

Commit 1a122c2

Browse files
committed
fix: add shellcheck disable directives to check scripts
Add appropriate shellcheck disable comments to suppress false positives: - SC2310: Functions in conditionals (intentional pattern) - SC2312: Masked return values (intentional) - SC2329: "Unused" functions (sourced by other scripts) - SC1091: Can't follow source (file exists at runtime)
1 parent 29b6911 commit 1a122c2

6 files changed

Lines changed: 7 additions & 0 deletions

File tree

t/scripts/check-ack.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#!/usr/bin/env bash
2+
# shellcheck disable=SC2310,SC2329
23
set -euo pipefail
34

45
# shellcheck source=checkhelper.sh

t/scripts/check-docker.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#!/usr/bin/env bash
2+
# shellcheck disable=SC1091,SC2310,SC2312,SC2329
23
set -euo pipefail
34

45
# shellcheck source=checkhelper.sh

t/scripts/check-go.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#!/usr/bin/env bash
2+
# shellcheck disable=SC2310,SC2329
23
set -euo pipefail
34

45
# shellcheck source=checkhelper.sh

t/scripts/check-gotestsum.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#!/usr/bin/env bash
2+
# shellcheck disable=SC2310
23
set -euo pipefail
34

45
# shellcheck source=checkhelper.sh

t/scripts/check-protoc.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#!/usr/bin/env bash
2+
# shellcheck disable=SC2310,SC2329
23
set -euo pipefail
34

45
# shellcheck source=checkhelper.sh

t/scripts/checkhelper.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
#!/usr/bin/env bash
2+
# shellcheck disable=SC2312
23
# Common functions for check scripts
4+
# This is a library sourced by other scripts - functions are invoked indirectly
35

46
err() { printf "ERROR: %s\n" "$*" >&2; }
57
warn() { printf "WARN: %s\n" "$*" >&2; }

0 commit comments

Comments
 (0)