Skip to content

Commit d539ef3

Browse files
committed
better error message for invalid inputs to angular_grid
1 parent 1886579 commit d539ef3

2 files changed

Lines changed: 22 additions & 7 deletions

File tree

CHANGES.rst

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,14 @@ Changelog
44
=========
55

66

7+
Version 2.X.Y
8+
-------------
9+
10+
Unreleased.
11+
12+
- Better error message for invalid inputs to angular_grid.
13+
14+
715
Version 2.0.1
816
-------------
917

src/lebedev.rs

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,10 @@ pub fn angular_grid(num_points: usize) -> (Vec<(f64, f64, f64)>, Vec<f64>) {
88

99
let offset: usize = match offsets.get(&num_points) {
1010
Some(v) => *v,
11-
None => panic!("angular_grid called with unsupported num_points"),
11+
None => panic!(
12+
"angular_grid called with unsupported num_points, allowed are: {:?}",
13+
valid_input_values()
14+
),
1215
};
1316

1417
(
@@ -18,6 +21,15 @@ pub fn angular_grid(num_points: usize) -> (Vec<(f64, f64, f64)>, Vec<f64>) {
1821
}
1922

2023
pub fn get_closest_num_angular(n: usize) -> usize {
24+
for number in valid_input_values() {
25+
if number >= n {
26+
return number;
27+
}
28+
}
29+
panic!("input n too high in get_closest_num_angular");
30+
}
31+
32+
fn valid_input_values() -> Vec<usize> {
2133
let offsets = tables::offsets::offsets();
2234

2335
let mut valid_numbers = Vec::new();
@@ -26,10 +38,5 @@ pub fn get_closest_num_angular(n: usize) -> usize {
2638
}
2739
valid_numbers.sort();
2840

29-
for number in valid_numbers {
30-
if number >= n {
31-
return number;
32-
}
33-
}
34-
panic!("input n too high in get_closest_num_angular");
41+
valid_numbers
3542
}

0 commit comments

Comments
 (0)