Address review: replace fragile StaticModifier with MethodModifiers in DummyMethodData

Use consistent MethodModifiers pattern ("partial" / "static partial") in
DummyMethodData, matching PartialMethodEmitData approach and eliminating
the fragile trailing-space convention.

Co-authored-by: dex3r <[email protected]>
Agent-Logs-Url: https://github.com/dex3r/EasySourceGenerators/sessions/cb205769-20ee-4e1e-9b44-3ef890163968

Author: Copilot

EasySourceGenerators.GeneratorTests/DummyImplementationEmitterTests.cs

@@ -19,7 +19,7 @@ public void Emit_SingleMethodWithNamespace_ContainsNamespaceDeclaration()
                 {
                     new DummyMethodData(
                         AccessibilityKeyword: "public",
-                        StaticModifier: "",
+                        MethodModifiers: "partial",
                         ReturnTypeName: "string",
                         MethodName: "GetValue",
                         ParameterList: "",
@@ -46,7 +46,7 @@ public void Emit_SingleMethodWithNamespace_ContainsClosingNamespaceBrace()
                 {
                     new DummyMethodData(
                         AccessibilityKeyword: "public",
-                        StaticModifier: "",
+                        MethodModifiers: "partial",
                         ReturnTypeName: "string",
                         MethodName: "GetValue",
                         ParameterList: "",
@@ -75,7 +75,7 @@ public void Emit_WithoutNamespace_DoesNotContainNamespaceDeclaration()
                 {
                     new DummyMethodData(
                         AccessibilityKeyword: "public",
-                        StaticModifier: "",
+                        MethodModifiers: "partial",
                         ReturnTypeName: "void",
                         MethodName: "DoWork",
                         ParameterList: "",
@@ -102,7 +102,7 @@ public void Emit_ContainsTypeDeclaration()
                 {
                     new DummyMethodData(
                         AccessibilityKeyword: "public",
-                        StaticModifier: "static ",
+                        MethodModifiers: "static partial",
                         ReturnTypeName: "int",
                         MethodName: "Calculate",
                         ParameterList: "",
@@ -129,7 +129,7 @@ public void Emit_ContainsMethodWithPartialKeyword()
                 {
                     new DummyMethodData(
                         AccessibilityKeyword: "public",
-                        StaticModifier: "",
+                        MethodModifiers: "partial",
                         ReturnTypeName: "string",
                         MethodName: "GetValue",
                         ParameterList: "",
@@ -156,7 +156,7 @@ public void Emit_StaticMethod_ContainsStaticModifier()
                 {
                     new DummyMethodData(
                         AccessibilityKeyword: "public",
-                        StaticModifier: "static ",
+                        MethodModifiers: "static partial",
                         ReturnTypeName: "int",
                         MethodName: "Compute",
                         ParameterList: "int x",
@@ -184,7 +184,7 @@ public void Emit_ContainsBodyStatement()
                 {
                     new DummyMethodData(
                         AccessibilityKeyword: "public",
-                        StaticModifier: "",
+                        MethodModifiers: "partial",
                         ReturnTypeName: "void",
                         MethodName: "DoWork",
                         ParameterList: "",
@@ -211,14 +211,14 @@ public void Emit_MultipleMethodsInSameType_ContainsBothMethods()
                 {
                     new DummyMethodData(
                         AccessibilityKeyword: "public",
-                        StaticModifier: "",
+                        MethodModifiers: "partial",
                         ReturnTypeName: "string",
                         MethodName: "First",
                         ParameterList: "",
                         BodyStatement: "throw new System.Exception();"),
                     new DummyMethodData(
                         AccessibilityKeyword: "internal",
-                        StaticModifier: "",
+                        MethodModifiers: "partial",
                         ReturnTypeName: "int",
                         MethodName: "Second",
                         ParameterList: "int x",
@@ -254,7 +254,7 @@ public void Emit_StructType_ContainsStructKeyword()
                 {
                     new DummyMethodData(
                         AccessibilityKeyword: "public",
-                        StaticModifier: "",
+                        MethodModifiers: "partial",
                         ReturnTypeName: "int",
                         MethodName: "GetValue",
                         ParameterList: "",

EasySourceGenerators.Generators/SourceEmitting/DummyImplementationEmitter.cs

@@ -18,7 +18,7 @@ internal sealed record DummyTypeGroupData(
 /// </summary>
 internal sealed record DummyMethodData(
     string AccessibilityKeyword,
-    string StaticModifier,
+    string MethodModifiers,
     string ReturnTypeName,
     string MethodName,
     string ParameterList,
@@ -50,7 +50,7 @@ internal static string Emit(IEnumerable<DummyTypeGroupData> typeGroups)
 
             foreach (DummyMethodData method in typeGroup.Methods)
             {
-                builder.AppendLine($"{method.AccessibilityKeyword} {method.StaticModifier}partial {method.ReturnTypeName} {method.MethodName}({method.ParameterList}) {{");
+                builder.AppendLine($"{method.AccessibilityKeyword} {method.MethodModifiers} {method.ReturnTypeName} {method.MethodName}({method.ParameterList}) {{");
                 builder.AppendLine(method.BodyStatement);
                 builder.AppendLine("}");
             }

EasySourceGenerators.Generators/SourceEmitting/RoslynSymbolDataMapper.cs

@@ -73,7 +73,7 @@ internal static IReadOnlyList<DummyTypeGroupData> ToDummyTypeGroups(IEnumerable<
             foreach (IMethodSymbol partialMethod in typeGroup)
             {
                 string accessibility = CSharpAccessibilityKeyword.FromOrEmpty(partialMethod.DeclaredAccessibility);
-                string staticModifier = partialMethod.IsStatic ? "static " : "";
+                string methodModifiers = partialMethod.IsStatic ? "static partial" : "partial";
                 string returnTypeName = partialMethod.ReturnType.ToDisplayString();
                 string parameterList = string.Join(", ", partialMethod.Parameters.Select(
                     parameter => $"{parameter.Type.ToDisplayString()} {parameter.Name}"));
@@ -83,7 +83,7 @@ internal static IReadOnlyList<DummyTypeGroupData> ToDummyTypeGroups(IEnumerable<
 
                 methods.Add(new DummyMethodData(
                     AccessibilityKeyword: accessibility,
-                    StaticModifier: staticModifier,
+                    MethodModifiers: methodModifiers,
                     ReturnTypeName: returnTypeName,
                     MethodName: partialMethod.Name,
                     ParameterList: parameterList,