Address code review: remove deprecated ExecuteFluentGeneratorMethod, improve ExtractBodyGenerationData fallback, comment out dead switch code in source builder

Co-authored-by: dex3r <[email protected]>
Agent-Logs-Url: https://github.com/dex3r/EasySourceGenerators/sessions/8070e196-96aa-4613-adf2-2df1ce631bfe

Author: Copilot

EasySourceGenerators.Generators/GeneratesMethodExecutionRuntime.cs

@@ -31,15 +31,8 @@ internal static (string? value, string? error) ExecuteSimpleGeneratorMethod(
         return ExecuteGeneratorMethodWithArgs(generatorMethod, allPartials, compilation, null);
     }
 
-    internal static (SwitchBodyData? record, string? error) ExecuteFluentGeneratorMethod(
-        IMethodSymbol generatorMethod,
-        IMethodSymbol partialMethod,
-        Compilation compilation)
-    {
-        // Kept for backward compatibility but no longer the primary path.
-        // SwitchCase-based fluent generation is being replaced by the data abstraction layer.
-        return (null, "SwitchCase-based fluent generation has been replaced by the data abstraction layer. Use ExecuteFluentBodyGeneratorMethod instead.");
-    }
+    // SwitchBodyData-based fluent execution has been replaced by the data abstraction layer.
+    // Use ExecuteFluentBodyGeneratorMethod instead.
 
     internal static (FluentBodyResult? result, string? error) ExecuteFluentBodyGeneratorMethod(
         IMethodSymbol generatorMethod,
@@ -301,8 +294,9 @@ private static FluentBodyResult ExtractBodyGenerationData(object methodResult, I
         PropertyInfo? dataProperty = resultType.GetProperty(Consts.BodyGenerationDataPropertyName);
         if (dataProperty == null)
         {
-            // The method returned something that isn't a DataMethodBodyGenerator - treat it as a simple return
-            return new FluentBodyResult(methodResult.ToString(), returnType.SpecialType == SpecialType.System_Void);
+            // The method returned something that isn't a DataMethodBodyGenerator.
+            // This may happen when the fluent chain is incomplete (e.g., user returned an intermediate builder).
+            return new FluentBodyResult(null, returnType.SpecialType == SpecialType.System_Void);
         }
 
         object? bodyGenerationData = dataProperty.GetValue(methodResult);

EasySourceGenerators.Generators/GeneratesMethodPatternSourceBuilder.cs

@@ -9,6 +9,9 @@ namespace EasySourceGenerators.Generators;
 
 internal static class GeneratesMethodPatternSourceBuilder
 {
+    // SwitchCase attribute-based and fluent switch generation are commented out pending replacement
+    // with a data-driven approach. See DataMethodBodyBuilders.cs for details.
+    /*
     internal static string GenerateFromSwitchAttributes(
         SourceProductionContext context,
         List<GeneratesMethodGenerationTarget> methods,
@@ -143,6 +146,7 @@ internal static string GenerateFromFluent(
 
         return GenerateSwitchMethodSource(containingType, partialMethod, switchBodyData.CasePairs, defaultExpression);
     }
+    */
 
     internal static string GenerateSimplePartialMethod(
         INamedTypeSymbol containingType,
@@ -163,6 +167,8 @@ internal static string GenerateSimplePartialMethod(
         return builder.ToString();
     }
 
+    // Switch-related helper methods are commented out pending replacement with data-driven approach
+    /*
     private static string? ExtractDefaultExpressionFromSwitchDefaultMethod(MethodDeclarationSyntax method)
     {
         ExpressionSyntax? bodyExpression = method.ExpressionBody?.Expression;
@@ -259,6 +265,23 @@ private static string GenerateSwitchMethodSource(
         return builder.ToString();
     }
 
+    private static string FormatKeyAsCSharpLiteral(object key, ITypeSymbol? parameterType)
+    {
+        if (parameterType?.TypeKind == TypeKind.Enum)
+        {
+            return $"{parameterType.ToDisplayString()}.{key}";
+        }
+
+        return key switch
+        {
+            bool b => b ? "true" : "false",
+            // SyntaxFactory.Literal handles escaping and quoting (e.g. "hello" → "\"hello\"")
+            string s => SyntaxFactory.Literal(s).Text,
+            _ => key.ToString()!
+        };
+    }
+    */
+
     private static void AppendNamespaceAndTypeHeader(StringBuilder builder, INamedTypeSymbol containingType, IMethodSymbol partialMethod)
     {
         builder.AppendLine("// <auto-generated/>");