fix: Bulk deploy panic and docker tag handling (#5949)

* removing fetchArtifacts V1 usage and abstracting tag extraction logic

* docker tag and repo method in util

* modifying image tag logic in release override

* wip: adding empty path check

* review changes

* fix: app update migration (#5903)

* wip: adding app name check

* wip

* wip

* wip

* moving migration to code

* wip: adding app name in log

* wip: moving sql logic to code

* pg no rows handling

* adding db migration call

* fixing fetch app query

* wip: adding pg multiple rows handling

* audit log update

* fix: nil ptr fix in copying extraEnvVars

* feat:  Docker lint plugin (#5694)

* added up script for docker linit plugin

* rename of script file

* docker lint down script

* changes in docker lint

* hadolint image

* change in name of plugin

* changes in down script

* chnages in docker lint

* chnages in down script

* change in hadolint image

* rename  down script file

* renaming sql script

* feat: Added Devtron CI Trigger v1.1.0 (#5934)

* Create 028901_019_devtron_ci_trigger_v1_1.down.sql

* Create 028901_019_devtron_ci_trigger_v1_1.up.sql

* Update 028901_019_devtron_ci_trigger_v1_1.up.sql

---------

Co-authored-by: Prakarsh <[email protected]>

* renaming docker lint script file (#5937)

* fix: err handling for configmap access

* release: PR for v0.7.3 (#5942)

* Update Chart.yaml

* Update devtron-bom.yaml

* Update values.yaml

* Update devtron-installer.yaml

* Update installation-script

* Update version.txt

* Update devtron.yaml

* Update releasenotes.md

* Update devtron-bom.yaml

* Update values.yaml

* Update releasenotes.md

* Update releasenotes.md

* Updated release-notes files

* Update releasenotes.md

* Update release.txt

* Updated release-notes files

* Update release-notes-v0.7.2.md

---------

Co-authored-by: ReleaseBot <[email protected]>

* wip: modifying tags function

* sync

---------

Co-authored-by: Gireesh Naidu <[email protected]>
Co-authored-by: Gireesh Naidu <[email protected]>
Co-authored-by: kamal-devtron <[email protected]>
Co-authored-by: Kiran <[email protected]>
Co-authored-by: Prakarsh <[email protected]>
Co-authored-by: Pawan Mehta <[email protected]>
Co-authored-by: ReleaseBot <[email protected]>

Author: 6 people

CHANGELOG/release-notes-v0.7.3.md

@@ -0,0 +1,7 @@
+## v0.7.3
+
+
+
+## Bugs
+- fix: Builds set to auto not getting triggered (#5925)
+- fix: User Rbac Fixes (#5940)

Wire.go

@@ -105,6 +105,7 @@ import (
 	security2 "github.com/devtron-labs/devtron/internal/sql/repository/security"
 	"github.com/devtron-labs/devtron/internal/util"
 	"github.com/devtron-labs/devtron/pkg/app"
+	"github.com/devtron-labs/devtron/pkg/app/dbMigration"
 	"github.com/devtron-labs/devtron/pkg/app/status"
 	"github.com/devtron-labs/devtron/pkg/appClone"
 	"github.com/devtron-labs/devtron/pkg/appClone/batch"
@@ -1005,6 +1006,9 @@ func InitializeApp() (*App, error) {
 
 		repocreds.NewServiceClientImpl,
 		wire.Bind(new(repocreds.ServiceClient), new(*repocreds.ServiceClientImpl)),
+
+		dbMigration.NewDbMigrationServiceImpl,
+		wire.Bind(new(dbMigration.DbMigration), new(*dbMigration.DbMigrationServiceImpl)),
 	)
 	return &App{}, nil
 }

api/restHandler/app/pipeline/configure/DeploymentPipelineRestHandler.go

@@ -1337,17 +1337,16 @@ func (handler *PipelineConfigRestHandlerImpl) GetArtifactsByCDPipeline(w http.Re
 		return
 	}
 	//rbac block ends here
-	var ciArtifactResponse *bean.CiArtifactResponse
-	if handler.pipelineRestHandlerEnvConfig.UseArtifactListApiV2 {
-		artifactsListFilterOptions := &bean2.ArtifactsListFilterOptions{
-			Limit:        limit,
-			Offset:       offset,
-			SearchString: searchString,
-		}
-		ciArtifactResponse, err = handler.pipelineBuilder.RetrieveArtifactsByCDPipelineV2(pipeline, bean2.WorkflowType(stage), artifactsListFilterOptions)
-	} else {
-		ciArtifactResponse, err = handler.pipelineBuilder.RetrieveArtifactsByCDPipeline(pipeline, bean2.WorkflowType(stage))
+	artifactsListFilterOptions := &bean2.ArtifactsListFilterOptions{
+		Limit:        limit,
+		Offset:       offset,
+		SearchString: searchString,
 	}
+
+	//RetrieveArtifactsByCDPipeline is deprecated and method is removed from code
+	//ciArtifactResponse, err = handler.pipelineBuilder.RetrieveArtifactsByCDPipeline(pipeline, bean2.WorkflowType(stage))
+
+	ciArtifactResponse, err := handler.pipelineBuilder.RetrieveArtifactsByCDPipelineV2(pipeline, bean2.WorkflowType(stage), artifactsListFilterOptions)
 	if err != nil {
 		handler.Logger.Errorw("service err, GetArtifactsByCDPipeline", "err", err, "cdPipelineId", cdPipelineId, "stage", stage)
 		common.WriteJsonResp(w, err, nil, http.StatusInternalServerError)

api/restHandler/app/pipeline/configure/PipelineConfigRestHandler.go

@@ -62,7 +62,7 @@ import (
 )
 
 type PipelineRestHandlerEnvConfig struct {
-	UseArtifactListApiV2 bool `env:"USE_ARTIFACT_LISTING_API_V2" envDefault:"true"`
+	UseArtifactListApiV2 bool `env:"USE_ARTIFACT_LISTING_API_V2" envDefault:"true"` //deprecated
 }
 
 type DevtronAppRestHandler interface {

assets/hadolint-icon.png

@@ -1,6 +1,6 @@
 apiVersion: v2
 name: devtron-operator
-appVersion: 0.7.2
+appVersion: 0.7.3
 description: Chart to configure and install Devtron. Devtron is a Kubernetes Orchestration system.
 keywords:
   - Devtron
@@ -11,7 +11,7 @@ keywords:
   - argocd
   - Hyperion
 engine: gotpl
-version: 0.22.74
+version: 0.22.75
 sources:
   - https://github.com/devtron-labs/charts
 dependencies:

charts/devtron/Chart.yaml

@@ -10,7 +10,7 @@ global:
   containerRegistry: "quay.io/devtron"
 extraManifests: []
 installer:
-  release: "v0.7.2"
+  release: "v0.7.3"
   registry: ""
   image: "inception"
   tag: "473deaa4-185-21582"
@@ -38,8 +38,8 @@ components:
     imagePullPolicy: IfNotPresent
   devtron:
     registry: ""
-    image: "hyperion:3f68456b-280-25566"
-    cicdImage: "devtron:3f68456b-434-25567"
+    image: "hyperion:e17c52eb-280-25812"
+    cicdImage: "devtron:e17c52eb-434-25813"
     imagePullPolicy: IfNotPresent
     customOverrides: {}
   ciRunner:

charts/devtron/devtron-bom.yaml

@@ -24,7 +24,7 @@ global:
 extraManifests: []
 installer:
   repo: "devtron-labs/devtron"
-  release: "v0.7.2"
+  release: "v0.7.3"
   registry: ""
   image: inception
   tag: 473deaa4-185-21582
@@ -81,8 +81,8 @@ components:
     imagePullPolicy: IfNotPresent
   devtron:
     registry: ""
-    image: "hyperion:3f68456b-280-25566"
-    cicdImage: "devtron:3f68456b-434-25567"
+    image: "hyperion:e17c52eb-280-25812"
+    cicdImage: "devtron:e17c52eb-434-25813"
     imagePullPolicy: IfNotPresent
     customOverrides: {}
     serviceMonitor:

charts/devtron/values.yaml

@@ -601,6 +601,10 @@ func (impl *TelemetryEventClientImpl) SendTelemetryDashboardAccessEvent() error
 		return err
 	}
 	cm, err := impl.K8sUtil.GetConfigMap(impl.aCDAuthConfig.ACDConfigMapNamespace, DevtronUniqueClientIdConfigMap, client)
+	if err != nil {
+		impl.logger.Errorw("DashboardAccessed EventForTelemetry,failed to get DevtronUniqueClientIdConfigMap", "error", err)
+		return err
+	}
 	datamap := cm.Data
 
 	accessEventValue, installEventKeyExists := datamap[UIEventKey]
@@ -667,6 +671,10 @@ func (impl *TelemetryEventClientImpl) SendTelemetryDashboardLoggedInEvent() erro
 		return err
 	}
 	cm, err := impl.K8sUtil.GetConfigMap(impl.aCDAuthConfig.ACDConfigMapNamespace, DevtronUniqueClientIdConfigMap, client)
+	if err != nil {
+		impl.logger.Errorw("DashboardLoggedIn EventForTelemetry,failed to get DevtronUniqueClientIdConfigMap", "error", err)
+		return err
+	}
 	datamap := cm.Data
 
 	accessEventValue, installEventKeyExists := datamap[UIEventKey]

client/telemetry/TelemetryEventClient.go

@@ -64,6 +64,7 @@ import (
 	security2 "github.com/devtron-labs/devtron/internal/sql/repository/security"
 	"github.com/devtron-labs/devtron/internal/util"
 	"github.com/devtron-labs/devtron/pkg/app"
+	"github.com/devtron-labs/devtron/pkg/app/dbMigration"
 	repository4 "github.com/devtron-labs/devtron/pkg/appStore/chartGroup/repository"
 	"github.com/devtron-labs/devtron/pkg/appStore/installedApp/service/EAMode"
 	"github.com/devtron-labs/devtron/pkg/appStore/installedApp/service/FullMode/deployment"
@@ -253,6 +254,9 @@ func InitializeApp() (*App, error) {
 
 		argoRepositoryCreds.NewRepositorySecret,
 		wire.Bind(new(argoRepositoryCreds.RepositorySecret), new(*argoRepositoryCreds.RepositorySecretImpl)),
+
+		dbMigration.NewDbMigrationServiceImpl,
+		wire.Bind(new(dbMigration.DbMigration), new(*dbMigration.DbMigrationServiceImpl)),
 	)
 	return &App{}, nil
 }