Skip to content

Commit 0fb7535

Browse files
committed
Streamlined repository helper binaries
1 parent 28b7aad commit 0fb7535

4 files changed

Lines changed: 15 additions & 11 deletions

File tree

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ _gen-readme-docs:
213213
@echo "################################################################################"
214214
@echo "# Generate doc/php-modules.md for PHP $(VERSION) ($(IMAGE):$(DOCKER_TAG)) on $(ARCH)"
215215
@echo "################################################################################"
216-
./bin/gen-readme.sh $(IMAGE) $(ARCH) $(STAGE) $(VERSION) || bash -x ./bin/gen-readme.sh $(IMAGE) $(ARCH) $(STAGE) $(VERSION)
216+
./bin/gen-docs-php-modules.sh $(IMAGE) $(ARCH) $(STAGE) $(VERSION) || bash -x ./bin/gen-docs-php-modules.sh $(IMAGE) $(ARCH) $(STAGE) $(VERSION)
217217
git diff --quiet || { echo "Build Changes"; git diff; git status; false; }
218218
@echo
219219

@@ -242,12 +242,12 @@ gen-dockerfiles:
242242
@echo "################################################################################"
243243
@echo "# Generating PHP modules"
244244
@echo "################################################################################"
245-
./bin/modules-generate.py $(MODS)
245+
./bin/gen-php-modules.py $(MODS)
246246
@echo
247247
@echo "################################################################################"
248248
@echo "# Generating Tools"
249249
@echo "################################################################################"
250-
./bin/tools-generate.py $(TOOLS)
250+
./bin/gen-php-tools.py $(TOOLS)
251251
@echo
252252
@echo "################################################################################"
253253
@echo "# Generating Dockerfiles"
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ set -o pipefail
99
SCRIPT_PATH="$(cd -P -- "$(dirname -- "$0")" && pwd -P)"
1010
SCRIPT_NAME="$(basename "${SCRIPT_PATH}")"
1111
REPO_PATH="${SCRIPT_PATH}/.."
12+
13+
###
14+
### This file is being updated
15+
###
1216
README="${REPO_PATH}/doc/php-modules.md"
1317

1418

@@ -105,14 +109,14 @@ get_modules_from_image() {
105109

106110

107111
###
108-
### Validate that README.md has all modules defined that are found in the PHP docker image
112+
### Validate that *.md file has all modules defined that are found in the PHP docker image
109113
###
110114
validate_readme() {
111115
local php_version="${1}"
112116
local modules_img="${2}" # Modules found in the PHP docker image
113117
local stage="${3}" # base or mods
114118

115-
# Check if README.md contains all modules we have retrieved from the PHP image
119+
# Check if *.md contains all modules we have retrieved from the PHP image
116120
while read -r line; do
117121
module="$( echo "${line}" | tr '[:upper:]' '[:lower:]' )"
118122
search="ext_${stage}_${module}_${php_version}"
@@ -126,7 +130,7 @@ validate_readme() {
126130

127131

128132
###
129-
### Update README.md for a specific PHP version
133+
### Update *.md for a specific PHP version
130134
###
131135
update_readme() {
132136
local php_version="${1}"
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -199,14 +199,14 @@ def write_group_vars(tools: List[str]) -> None:
199199
# --------------------------------------------------------------------------------------------------
200200
def print_help() -> None:
201201
"""Show help screen."""
202-
print("Usage:", os.path.basename(__file__), "[options] [PHP-EXT]...")
202+
print("Usage:", os.path.basename(__file__), "[options] [PHP-TOOL]...")
203203
print(" ", os.path.basename(__file__), "-h, --help")
204204
print()
205205
print("This script will generate the Ansible group_vars file: .ansible/group_vars/all/work.yml")
206206
print("based on all the tools found in php_tools/ directory.")
207207
print()
208208
print("Positional arguments:")
209-
print(" [PHP-EXT] Specify None, one or more PHP tools to generate group_vars for.")
209+
print(" [PHP-TOOL] Specify None, one or more PHP tools to generate group_vars for.")
210210
print(" When no PHP tool is specified (argument is omitted), group_vars")
211211
print(" for all tools will be genrated.")
212212
print(" When one or more PHP tool are specified, only group_vars for")
@@ -219,9 +219,9 @@ def print_help() -> None:
219219
print(" the changes to take effect, before building the image.")
220220
print("Optional arguments:")
221221
print(" -i Ignore dependent tools.")
222-
print(" By default each exentions is checked for build dependencies of other")
223-
print(" tools. For example many tools build against libxml ext.")
224-
print(" By specifying -i, those dependencies are not beeing added to")
222+
print(" By default each tool is checked for dependencies of other")
223+
print(" tools.")
224+
print(" By specifying -i, those dependent tools are not beeing added to")
225225
print(" ansible group_vars. Use at your own risk.")
226226

227227

0 commit comments

Comments
 (0)