Skip to content

Commit 6c7cb4d

Browse files
authored
Incorporated Review Comment
1 parent fce346b commit 6c7cb4d

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

.github/workflows/release.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
permissions:
1313
packages: write
1414
steps:
15-
- uses: actions/checkout@v4
15+
- uses: actions/checkout@v2
1616

1717
- name: "Publish"
1818
uses: devcontainers/action@v1

.github/workflows/test-pr.yaml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
outputs:
99
templates: ${{ steps.filter.outputs.changes }}
1010
steps:
11-
- uses: dorny/paths-filter@v3
11+
- uses: dorny/paths-filter@v2
1212
id: filter
1313
with:
1414
filters: |
@@ -58,7 +58,7 @@ jobs:
5858
matrix:
5959
templates: ${{ fromJSON(needs.detect-changes.outputs.templates) }}
6060
steps:
61-
- uses: actions/checkout@v4
61+
- uses: actions/checkout@v2
6262

6363
- name: "Install latest devcontainer CLI"
6464
run: npm install -g @devcontainers/cli
@@ -74,7 +74,7 @@ jobs:
7474
# Configure templates only if `devcontainer-template.json` contains the `options` property.
7575
optionProp=( $(jq -r '.options' devcontainer-template.json) )
7676
77-
if [ "${optionProp}" != "" ] && [ "${optionProp}" != "null" ] ; then
77+
if [ "${optionProp}" != "" ] && [ "${optionProp}" != "null" ] ; then
7878
options=( $(jq -r '.options | keys[]' devcontainer-template.json) )
7979
8080
if [ "${options[0]}" != "" ] && [ "${options[0]}" != "null" ] ; then
@@ -101,7 +101,7 @@ jobs:
101101
template_id="${{ matrix.templates }}"
102102
src_dir="test/${template_id}"
103103
104-
if [ ! -d "$(pwd)/${src_dir}" ] ; then
104+
if [ ! -d "$(pwd)/${src_dir}" ] ; then
105105
echo "Template '${{ matrix.templates }}' is missing a test folder"
106106
exit 1
107107
fi
@@ -119,11 +119,11 @@ jobs:
119119
# Fake out existence of extensions, VS Code Server to validate extensions
120120
echo "(*) Stubbing out extensions and VS Code Server..."
121121
122-
# Configuring path for 'devcontainer.json'
122+
# Configuring path for 'devcontainer.json'
123123
dev_container_relative_path="src/${template_id}"
124124
dev_container_json_name=".devcontainer.json"
125125
126-
if [ -d "$(pwd)/${dev_container_relative_path}/.devcontainer" ] ; then
126+
if [ -d "$(pwd)/${dev_container_relative_path}/.devcontainer" ] ; then
127127
dev_container_relative_path="${dev_container_relative_path}/.devcontainer"
128128
dev_container_json_name="devcontainer.json"
129129
fi
@@ -136,7 +136,7 @@ jobs:
136136
# Fetching extensions list defined in 'devcontainer.json'
137137
extensions="$(jq '.extensions' --compact-output "${dev_container_tmp}" | tr -d '[' | tr -d ']' | tr ',' '\n' 2>/dev/null || echo -n '')"
138138
139-
# Stubbing extensions list for the tests validation with checkExtension()
139+
# Stubbing extensions list for the tests validation with checkExtension()
140140
devcontainer exec --workspace-folder "src/${template_id}/" --id-label ${id_label} /bin/sh -c "\
141141
mkdir -p \$HOME/.vscode-server/bin \$HOME/.vscode-server/extensions \
142142
&& cd \$HOME/.vscode-server/extensions \

.github/workflows/update-documentation.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
pull-requests: write
1515
if: "github.ref == 'refs/heads/main'"
1616
steps:
17-
- uses: actions/checkout@v4
17+
- uses: actions/checkout@v3
1818

1919
- name: Generate Documentation
2020
uses: devcontainers/action@v1

0 commit comments

Comments
 (0)