From 5682dffe6ce11694bd9291ad5863ef6c3bab23fd Mon Sep 17 00:00:00 2001 From: Kaniska Date: Fri, 23 May 2025 08:02:37 +0000 Subject: [PATCH 1/5] Ubuntu focal EOL change for nvidia-cuda --- src/nvidia-cuda/devcontainer-feature.json | 2 +- src/nvidia-cuda/install.sh | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/nvidia-cuda/devcontainer-feature.json b/src/nvidia-cuda/devcontainer-feature.json index 7ed66478f..e31ffa047 100644 --- a/src/nvidia-cuda/devcontainer-feature.json +++ b/src/nvidia-cuda/devcontainer-feature.json @@ -1,6 +1,6 @@ { "id": "nvidia-cuda", - "version": "1.2.1", + "version": "1.2.2", "name": "NVIDIA CUDA", "description": "Installs shared libraries for NVIDIA CUDA.", "documentationURL": "https://github.com/devcontainers/features/tree/main/src/nvidia-cuda", diff --git a/src/nvidia-cuda/install.sh b/src/nvidia-cuda/install.sh index a1055ac45..15d7b3b67 100644 --- a/src/nvidia-cuda/install.sh +++ b/src/nvidia-cuda/install.sh @@ -46,7 +46,8 @@ check_packages wget ca-certificates # Add NVIDIA's package repository to apt so that we can download packages # Always use the ubuntu2004 repo because the other repos (e.g., debian11) are missing packages -NVIDIA_REPO_URL="https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2004/x86_64" +# Updating the repo to ubuntu2204 as ubuntu 20.04 is going out of support +NVIDIA_REPO_URL="https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2204/x86_64" KEYRING_PACKAGE="cuda-keyring_1.0-1_all.deb" KEYRING_PACKAGE_URL="$NVIDIA_REPO_URL/$KEYRING_PACKAGE" KEYRING_PACKAGE_PATH="$(mktemp -d)" From 0d254d783ea629ae3620bb39ff052e03804f64ff Mon Sep 17 00:00:00 2001 From: Kaniska Date: Fri, 6 Jun 2025 07:17:27 +0000 Subject: [PATCH 2/5] Major version bump --- src/nvidia-cuda/devcontainer-feature.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nvidia-cuda/devcontainer-feature.json b/src/nvidia-cuda/devcontainer-feature.json index e31ffa047..1b074c813 100644 --- a/src/nvidia-cuda/devcontainer-feature.json +++ b/src/nvidia-cuda/devcontainer-feature.json @@ -1,6 +1,6 @@ { "id": "nvidia-cuda", - "version": "1.2.2", + "version": "1.3.0", "name": "NVIDIA CUDA", "description": "Installs shared libraries for NVIDIA CUDA.", "documentationURL": "https://github.com/devcontainers/features/tree/main/src/nvidia-cuda", From 09e65f78b4263fdd108ee64a3424d8a802afd5f9 Mon Sep 17 00:00:00 2001 From: Kaniska Date: Fri, 6 Jun 2025 11:08:59 +0000 Subject: [PATCH 3/5] Major version bump correctly as per the review comment. --- src/nvidia-cuda/devcontainer-feature.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nvidia-cuda/devcontainer-feature.json b/src/nvidia-cuda/devcontainer-feature.json index 1b074c813..7dd46f7c0 100644 --- a/src/nvidia-cuda/devcontainer-feature.json +++ b/src/nvidia-cuda/devcontainer-feature.json @@ -1,6 +1,6 @@ { "id": "nvidia-cuda", - "version": "1.3.0", + "version": "2.0.0", "name": "NVIDIA CUDA", "description": "Installs shared libraries for NVIDIA CUDA.", "documentationURL": "https://github.com/devcontainers/features/tree/main/src/nvidia-cuda", From b877eb5e11605f2894436b941140717f6f4a34de Mon Sep 17 00:00:00 2001 From: Kaniska Date: Thu, 12 Jun 2025 05:37:02 +0000 Subject: [PATCH 4/5] Updating the correct version in readme file as pointed out in review. --- src/nvidia-cuda/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nvidia-cuda/README.md b/src/nvidia-cuda/README.md index e5b9d4012..7c18f0432 100644 --- a/src/nvidia-cuda/README.md +++ b/src/nvidia-cuda/README.md @@ -7,7 +7,7 @@ Installs shared libraries for NVIDIA CUDA. ```json "features": { - "ghcr.io/devcontainers/features/nvidia-cuda:1": {} + "ghcr.io/devcontainers/features/nvidia-cuda:2": {} } ``` From 79fa5630563de6d2b6d2e80e97230d18e5016c07 Mon Sep 17 00:00:00 2001 From: Kaniska Date: Tue, 17 Jun 2025 06:53:57 +0000 Subject: [PATCH 5/5] To re-run the tests --- src/nvidia-cuda/install.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nvidia-cuda/install.sh b/src/nvidia-cuda/install.sh index 15d7b3b67..ca309fb25 100644 --- a/src/nvidia-cuda/install.sh +++ b/src/nvidia-cuda/install.sh @@ -46,7 +46,7 @@ check_packages wget ca-certificates # Add NVIDIA's package repository to apt so that we can download packages # Always use the ubuntu2004 repo because the other repos (e.g., debian11) are missing packages -# Updating the repo to ubuntu2204 as ubuntu 20.04 is going out of support +# Updating the repo to ubuntu2204 as ubuntu 20.04 is going out of support. NVIDIA_REPO_URL="https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2204/x86_64" KEYRING_PACKAGE="cuda-keyring_1.0-1_all.deb" KEYRING_PACKAGE_URL="$NVIDIA_REPO_URL/$KEYRING_PACKAGE"