[node] - Fixing issue due to expired GPG key for yarn. (#1546)

* [node] - Fixing issue due to expised GPG key for yarn.

* Changing back to debian 11

* Fixing failing tests

* Trigger test again

Author: Kaniska244

src/node/devcontainer-feature.json

@@ -1,7 +1,7 @@
 {
     "id": "node",
-    "version": "1.6.3",
-    "name": "Node.js (via nvm), yarn and pnpm",
+    "version": "1.6.4",
+    "name": "Node.js (via nvm), yarn and pnpm.",
     "documentationURL": "https://github.com/devcontainers/features/tree/main/src/node",
     "description": "Installs Node.js, nvm, yarn, pnpm, and needed dependencies.",
     "options": {

src/node/install.sh

@@ -203,8 +203,15 @@ install_yarn() {
         # via apt-get on Debian systems
         if ! type yarn >/dev/null 2>&1; then
             # Import key safely (new method rather than deprecated apt-key approach) and install
-            curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | gpg --dearmor > /usr/share/keyrings/yarn-archive-keyring.gpg
-            echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/yarn-archive-keyring.gpg] https://dl.yarnpkg.com/debian/ stable main" > /etc/apt/sources.list.d/yarn.list
+            if [ "${VERSION_CODENAME}" = "trixie" ]; then
+                # Trixie requires fetching the key from keys.openpgp.org
+                mkdir -p /etc/apt/keyrings
+                curl -fsSL "https://keys.openpgp.org/vks/v1/by-fingerprint/72ECF46A56B4AD39C907BBB71646B01B86E50310" | gpg --dearmor --yes -o /etc/apt/keyrings/yarn-archive-keyring.gpg
+                echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/yarn-archive-keyring.gpg] https://dl.yarnpkg.com/debian/ stable main" > /etc/apt/sources.list.d/yarn.list
+            else
+                curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | gpg --dearmor > /usr/share/keyrings/yarn-archive-keyring.gpg
+                echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/yarn-archive-keyring.gpg] https://dl.yarnpkg.com/debian/ stable main" > /etc/apt/sources.list.d/yarn.list
+            fi
             apt-get update
             apt-get -y install --no-install-recommends yarn
         else

test/node/install_additional_node.sh

@@ -6,12 +6,12 @@ set -e
 source dev-container-features-test-lib
 
 # 'lts' is now some version of node 22...
-check "version_on_path"  node -v | grep 22
+check "version_on_path" bash -c "node -v | grep 24"
 check "pnpm" bash -c "pnpm -v | grep 8.8.0"
 
-check "v20_installed" ls -1 /usr/local/share/nvm/versions/node | grep 20.19.1
-check "v19_installed" ls -1 /usr/local/share/nvm/versions/node | grep 19.9.0
+check "v20_installed" bash -c "ls -1 /usr/local/share/nvm/versions/node | grep 20.19.1"
+check "v19_installed" bash -c "ls -1 /usr/local/share/nvm/versions/node | grep 19.9.0"
 
 
 # Report result
-reportResults
+reportResults

test/node/install_additional_node_on_rhel_family.sh

@@ -6,12 +6,11 @@ set -e
 source dev-container-features-test-lib
 
 # 'lts' is now some version of node 22...
-check "version_on_path"  node -v | grep 22
+check "version_on_path" bash -c "node -v | grep 24"
 check "pnpm" bash -c "pnpm -v | grep 6.16.0"
 
-check "v20_installed" ls -1 /usr/local/share/nvm/versions/node | grep 20
-check "v19_installed" ls -1 /usr/local/share/nvm/versions/node | grep 19.9.0
-check "v20_installed" ls -1 /usr/local/share/nvm/versions/node | grep 20.19.1
+check "v19_installed" bash -c "ls -1 /usr/local/share/nvm/versions/node | grep 19.9.0"
+check "v20_installed" bash -c "ls -1 /usr/local/share/nvm/versions/node | grep 20.19.1"
 
 
 # Report result

test/node/install_node_debian_bookworm.sh

@@ -0,0 +1,17 @@
+#!/bin/bash
+
+set -e
+
+# Optional: Import test library
+source dev-container-features-test-lib
+
+# Definition specific tests
+check "version" node  --version
+check "pnpm" pnpm -v
+check "nvm" bash -c ". /usr/local/share/nvm/nvm.sh && nvm install 10"
+check "yarn" yarn --version
+
+# Report result
+reportResults
+
+

test/node/install_node_debian_trixie.sh

@@ -0,0 +1,17 @@
+#!/bin/bash
+
+set -e
+
+# Optional: Import test library
+source dev-container-features-test-lib
+
+# Definition specific tests
+check "version" node  --version
+check "pnpm" pnpm -v
+check "nvm" bash -c ". /usr/local/share/nvm/nvm.sh && nvm install 10"
+check "yarn" yarn --version
+
+# Report result
+reportResults
+
+

test/node/scenarios.json

@@ -1,4 +1,20 @@
 {
+    "install_node_debian_trixie": {
+        "image": "debian:13",
+        "features": {
+            "node": {
+                "version": "lts"
+            }
+        }
+    },    
+    "install_node_debian_bookworm": {
+        "image": "debian:12",
+        "features": {
+            "node": {
+                "version": "lts"
+            }
+        }
+    },    
     "nvm_test_fallback": {
         "image": "debian:11",
         "features": {