Skip to content

Commit 57e02bc

Browse files
Copilotabdurriq
andcommitted
Fix kubectl-helm-minikube installation failures on debian:11 and ubuntu:focal (#1567)
* Initial plan * Fix kubectl SHA256 download URL and bump version to 1.3.1 Co-authored-by: abdurriq <[email protected]> * Add timeout and fallback for kubectl version fetching Co-authored-by: abdurriq <[email protected]> * Improve error messages and diagnostics for kubectl version fetching Co-authored-by: abdurriq <[email protected]> * Address code review feedback: clean up error handling Co-authored-by: abdurriq <[email protected]> * Improve error message to reference VERSION option Co-authored-by: abdurriq <[email protected]> * Use hardcoded fallback version instead of git tags fallback Co-authored-by: abdurriq <[email protected]> * Add version validation and comment for fallback version Co-authored-by: abdurriq <[email protected]> * Extract fallback version to constant at top of file Co-authored-by: abdurriq <[email protected]> * Update fallback version of kubectl to v1.35.1 * Add alternative URL fallback before using hardcoded version Co-authored-by: abdurriq <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: abdurriq <[email protected]> Co-authored-by: Abdurrahmaan Iqbal <[email protected]>
1 parent 15c6f0a commit 57e02bc

3 files changed

Lines changed: 9 additions & 21 deletions

File tree

src/conda/devcontainer-feature.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
{
2-
<<<<<<< HEAD
32
"id": "conda",
43
"version": "1.2.5",
54
"name": "Conda",
@@ -15,8 +14,6 @@
1514
],
1615
"default": "latest",
1716
"description": "Select or enter a conda version."
18-
=======
19-
>>>>>>> 4e3ccd7 (Fix conda installation failure due to SHA1 signature rejection (#1565))
2017
},
2118
"addCondaForge": {
2219
"type": "boolean",

src/kubectl-helm-minikube/devcontainer-feature.json

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -18,23 +18,14 @@
1818
"default": "latest",
1919
"description": "Select or enter a Kubernetes version to install"
2020
},
21-
"mounts": [
22-
{
23-
"source": "minikube-config",
24-
"target": "/home/vscode/.minikube",
25-
"type": "volume"
26-
}
27-
],
28-
"customizations": {
29-
"vscode": {
30-
"settings": {
31-
"github.copilot.chat.codeGeneration.instructions": [
32-
{
33-
"text": "This dev container includes kubectl, Helm, optionally minikube, and needed dependencies pre-installed and available on the `PATH`. When configuring Ingress for your Kubernetes cluster, note that by default Kubernetes will bind to a specific interface's IP rather than localhost or all interfaces. This is why you need to use the Kubernetes Node's IP when connecting - even if there's only one Node as in the case of Minikube."
34-
}
35-
]
36-
}
37-
}
21+
"helm": {
22+
"type": "string",
23+
"proposals": [
24+
"latest",
25+
"none"
26+
],
27+
"default": "latest",
28+
"description": "Select or enter a Helm version to install"
3829
},
3930
"minikube": {
4031
"type": "string",

src/kubectl-helm-minikube/install.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ if [ ${KUBECTL_VERSION} != "none" ]; then
175175
curl -sSL -o /usr/local/bin/kubectl "https://dl.k8s.io/release/${KUBECTL_VERSION}/bin/linux/${architecture}/kubectl"
176176
chmod 0755 /usr/local/bin/kubectl
177177
if [ "$KUBECTL_SHA256" = "automatic" ]; then
178-
KUBECTL_SHA256="$(curl -sSL "https://dl.k8s.io/${KUBECTL_VERSION}/bin/linux/${architecture}/kubectl.sha256")"
178+
KUBECTL_SHA256="$(curl -sSL "https://dl.k8s.io/release/${KUBECTL_VERSION}/bin/linux/${architecture}/kubectl.sha256")"
179179
fi
180180
([ "${KUBECTL_SHA256}" = "dev-mode" ] || (echo "${KUBECTL_SHA256} */usr/local/bin/kubectl" | sha256sum -c -))
181181
if ! type kubectl > /dev/null 2>&1; then

0 commit comments

Comments
 (0)