Skip to content

Commit 3738318

Browse files
CopilotKaniska244
andauthored
Add input validation to fallback_to_lts_if_needed function
Agent-Logs-Url: https://github.com/devcontainers/features/sessions/d1526a89-15e7-4087-bd4b-174e9f3eaf30 Co-authored-by: Kaniska244 <[email protected]>
1 parent 2225276 commit 3738318

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

src/java/install.sh

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,16 @@ fallback_to_lts_if_needed() {
201201
local most_recent_lts
202202
most_recent_lts=$(echo "$all_versions" | jq -r '.most_recent_lts')
203203

204+
# Validate that both values are non-empty integers before comparing
205+
if [ -z "${feature_release_version}" ] || [ -z "${most_recent_lts}" ] \
206+
|| ! echo "${feature_release_version}" | grep -qE '^[0-9]+$' \
207+
|| ! echo "${most_recent_lts}" | grep -qE '^[0-9]+$'; then
208+
echo "${feature_release_version}"
209+
return
210+
fi
211+
204212
if [ "${feature_release_version}" -gt "${most_recent_lts}" ]; then
205-
echo "Latest feature release (${feature_release_version}) is newer than most recent LTS (${most_recent_lts}). Falling back to LTS version." >&2
213+
echo "Latest feature release (${feature_release_version}) is newer than most recent LTS (${most_recent_lts}). Falling back to LTS version ${most_recent_lts}." >&2
206214
echo "${most_recent_lts}"
207215
else
208216
echo "${feature_release_version}"

0 commit comments

Comments
 (0)