Skip to content

Commit 324b928

Browse files
committed
Node 18 EOL changes
1 parent 6654579 commit 324b928

3 files changed

Lines changed: 22 additions & 8 deletions

File tree

src/node/devcontainer-feature.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"id": "node",
3-
"version": "1.6.2",
3+
"version": "1.6.3",
44
"name": "Node.js (via nvm), yarn and pnpm",
55
"documentationURL": "https://github.com/devcontainers/features/tree/main/src/node",
66
"description": "Installs Node.js, nvm, yarn, pnpm, and needed dependencies.",
@@ -11,9 +11,8 @@
1111
"lts",
1212
"latest",
1313
"none",
14-
"18",
15-
"16",
16-
"14"
14+
"22",
15+
"20"
1716
],
1817
"default": "lts",
1918
"description": "Select or enter a Node.js version to install"
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
#!/bin/bash
2+
3+
set -e
4+
5+
# Optional: Import test library
6+
source dev-container-features-test-lib
7+
8+
# Definition specific tests
9+
check "version" bash -c "node --version | grep 22"
10+
check "pnpm" bash -c "pnpm -v | grep 8.8.0"
11+
check "nvm" bash -c ". /usr/local/share/nvm/nvm.sh && nvm install 10"
12+
13+
# Report result
14+
reportResults
15+

test/node/scenarios.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,11 @@
7777
}
7878
}
7979
},
80-
"install_node_16_on_bionic": {
81-
"image": "mcr.microsoft.com/devcontainers/base:ubuntu-18.04",
80+
"install_node_22_on_jammy": {
81+
"image": "mcr.microsoft.com/devcontainers/base:ubuntu-22.04",
8282
"features": {
8383
"node": {
84-
"version": "16",
84+
"version": "22",
8585
"pnpmVersion":"8.8.0"
8686
}
8787
}
@@ -200,4 +200,4 @@
200200
}
201201
}
202202
}
203-
}
203+
}

0 commit comments

Comments
 (0)